Skip to content

Add support for ecdsa and ed25519 public keys.#3740

Merged
yadvr merged 1 commit intoapache:masterfrom
cl-k-takahashi:patch-public-keys
Dec 6, 2019
Merged

Add support for ecdsa and ed25519 public keys.#3740
yadvr merged 1 commit intoapache:masterfrom
cl-k-takahashi:patch-public-keys

Conversation

@cl-k-takahashi
Copy link
Copy Markdown
Contributor

@cl-k-takahashi cl-k-takahashi commented Dec 4, 2019 •
edited by DaanHoogland
Loading

Signed-off-by: Kai Takahashi k-takahashi@creationline.com

Description

See #3705

Fixes: #3705

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)

Screenshots (if appropriate):

How Has This Been Tested?

Created a vm with ed25519 public key and I logged into it with ssh.

@cl-k-takahashi
Add support for ecdsa and ed25519 public keys.
e2c0777 
Signed-off-by: Kai Takahashi <k-takahashi@creationline.com>
DaanHoogland
DaanHoogland approved these changes Dec 5, 2019
View reviewed changes
Copy link
Copy Markdown
Contributor

@DaanHoogland DaanHoogland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code looks code, user tested, let's run regression tests and merge.

@DaanHoogland
Copy link
Copy Markdown
Contributor

DaanHoogland commented Dec 5, 2019

@blueorangutan package

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Dec 5, 2019

@DaanHoogland a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Dec 5, 2019

Packaging result: ✖centos6 ✔centos7 ✔debian. JID-426

@DaanHoogland
Copy link
Copy Markdown
Contributor

DaanHoogland commented Dec 5, 2019

@blueorangutan test

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Dec 5, 2019

@DaanHoogland a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Dec 5, 2019

Trillian test result (tid-580)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 39940 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr3740-t580-kvm-centos7.zip
Intermittent failure detected: /marvin/tests/smoke/test_privategw_acl.py
Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py
Intermittent failure detected: /marvin/tests/smoke/test_vpc_vpn.py
Smoke tests completed. 77 look OK, 0 have error(s)
Only failed tests results shown below:

Test Result Time (s) Test File

@weizhouapache
Copy link
Copy Markdown
Member

weizhouapache commented Dec 6, 2019

code LGTM

svenvogel
svenvogel approved these changes Dec 6, 2019
View reviewed changes
Copy link
Copy Markdown
Contributor

@svenvogel svenvogel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGMT!

@yadvr yadvr added this to the 4.14.0.0 milestone Dec 6, 2019
@yadvr yadvr merged commit e56fa31 into apache:master Dec 6, 2019
ustcweizhou pushed a commit to ustcweizhou/cloudstack that referenced this pull request Feb 28, 2020
@cl-k-takahashi @ustcweizhou
ssh: Add support for ecdsa and ed25519 public keys (apache#3740)
b8acb0a 
See apache#3705
Fixes: apache#3705

Signed-off-by: Kai Takahashi <k-takahashi@creationline.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@DaanHoogland DaanHoogland DaanHoogland approved these changes

@svenvogel svenvogel svenvogel approved these changes

Assignees

No one assigned

Labels

type:enhancement type:security

Projects

None yet

Milestone

4.14.0.0

Development

Successfully merging this pull request may close these issues.

ecdsa and ed25519 support for sshkeys

6 participants

@cl-k-takahashi @DaanHoogland @blueorangutan @weizhouapache @svenvogel @yadvr