Skip to content

Save SSH.PublicKey into user_vm_details regardless of password management.#3745

Merged
yadvr merged 1 commit intoapache:masterfrom
cl-k-takahashi:patch-save-ssh-publickey
Dec 6, 2019
Merged

Save SSH.PublicKey into user_vm_details regardless of password management.#3745
yadvr merged 1 commit intoapache:masterfrom
cl-k-takahashi:patch-save-ssh-publickey

Conversation

@cl-k-takahashi
Copy link
Copy Markdown
Contributor

@cl-k-takahashi cl-k-takahashi commented Dec 5, 2019 •
edited by DaanHoogland
Loading

See #3744

Signed-off-by: Kai Takahashi k-takahashi@creationline.com

Description

Fixes: #3744

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)

Screenshots (if appropriate):

How Has This Been Tested?

Checked that SSH.PublicKey in user_vm_details is updated when I call resetSSHKeyForVirtualMachine API.

@cl-k-takahashi
Save SSH.PublicKey into user_vm_details regardless of password manage…
150a788 
…ment.

Signed-off-by: Kai Takahashi <k-takahashi@creationline.com>
@weizhouapache
Copy link
Copy Markdown
Member

weizhouapache commented Dec 5, 2019

code LGTM

DaanHoogland
DaanHoogland approved these changes Dec 5, 2019
View reviewed changes
Copy link
Copy Markdown
Contributor

@DaanHoogland DaanHoogland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code lgtm

@DaanHoogland
Copy link
Copy Markdown
Contributor

DaanHoogland commented Dec 5, 2019

@blueorangutan package

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Dec 5, 2019

@DaanHoogland a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Dec 5, 2019

Packaging result: ✖centos6 ✔centos7 ✔debian. JID-427

@DaanHoogland
Copy link
Copy Markdown
Contributor

DaanHoogland commented Dec 5, 2019

@blueorangutan test

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Dec 5, 2019

@DaanHoogland a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Dec 5, 2019

Trillian test result (tid-579)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 41141 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr3745-t579-kvm-centos7.zip
Intermittent failure detected: /marvin/tests/smoke/test_vm_life_cycle.py
Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py
Intermittent failure detected: /marvin/tests/smoke/test_hostha_kvm.py
Smoke tests completed. 76 look OK, 1 have error(s)
Only failed tests results shown below:

Test Result Time (s) Test File
test_hostha_kvm_host_fencing Failure 705.82 test_hostha_kvm.py

@yadvr yadvr added this to the 4.14.0.0 milestone Dec 6, 2019
@yadvr yadvr merged commit 6f3694c into apache:master Dec 6, 2019
@cl-k-takahashi cl-k-takahashi deleted the patch-save-ssh-publickey branch December 12, 2019 01:22
ustcweizhou pushed a commit to ustcweizhou/cloudstack that referenced this pull request Feb 28, 2020
@cl-k-takahashi @ustcweizhou
server: save SSH.PublicKey into user_vm_details regardless of passwor…
37b36fe 
…d management (apache#3745)

Fixes: apache#3744

Signed-off-by: Kai Takahashi <k-takahashi@creationline.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yadvr yadvr yadvr approved these changes

@DaanHoogland DaanHoogland DaanHoogland approved these changes

Assignees

No one assigned

Labels

type:bug type:security

Projects

None yet

Milestone

4.14.0.0

Development

Successfully merging this pull request may close these issues.

SSH.PublicKey in user_vm_details overrides public key set by resetSSHKeyForVirtualMachine API.

6 participants

@cl-k-takahashi @weizhouapache @DaanHoogland @blueorangutan @yadvr @svenvogel