Skip to content

refact: support py 3.12 & improve the graph rag config experience#53

Merged
liuxiaocs7 merged 1 commit intomainfrom
rag
Jul 3, 2024
Merged

refact: support py 3.12 & improve the graph rag config experience#53
liuxiaocs7 merged 1 commit intomainfrom
rag

Conversation

@imbajin
Copy link
Copy Markdown
Member

@imbajin imbajin commented Jul 1, 2024

🚧 WIP status:

  • Support Python 3.12 (We need test in different env, currently tested in MacOS ARM), add it in CI env later

Other TODOs moved to #54

@dosubot dosubot Bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Jul 1, 2024
@imbajin imbajin marked this pull request as draft July 1, 2024 10:46
@github-actions github-actions Bot added the llm label Jul 1, 2024
@dosubot dosubot Bot added the documentation Improvements or additions to documentation label Jul 1, 2024
@ChenZiHong-Gavin
Copy link
Copy Markdown
Collaborator

ChenZiHong-Gavin commented Jul 3, 2024

Tested Python3.12 on win11, and found the problem.
Versions of tiktoken before 0.5.2 did not build Python3.12 wheels, see main/CHANGELOG.md#v052

RUN pip install tiktoken>=0.5.2

refer: openai/tiktoken#264

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jul 3, 2024

Dependency Review

The following issues were found:
  • ❌ 1 vulnerable package(s)
  • ✅ 0 package(s) with incompatible licenses
  • ✅ 0 package(s) with invalid SPDX license definitions
  • ✅ 0 package(s) with unknown licenses.
See the Details below.

Vulnerabilities

hugegraph-llm/requirements.txt

NameVersionVulnerabilitySeverity
gradio4.29.0Server-Side Request Forgery in gradiohigh
Local file inclusion in gradiohigh
Open redirect in gradiomoderate

Scanned Manifest Files

hugegraph-llm/requirements.txt
  • gradio@4.29.0
  • gradio@4.19.2
  • tiktoken@0.7.0
  • tiktoken@0.5.1

@imbajin
Copy link
Copy Markdown
Member Author

imbajin commented Jul 3, 2024

Tested Python3.12 on win11, and found the problem. Versions of tiktoken before 0.5.2 did not build Python3.12 wheels, see main/CHANGELOG.md#v052

RUN pip install tiktoken>=0.5.2

refer: openai/tiktoken#264

THX, already updated the dependencies (try the latest code maybe)

@liuxiaocs7 merge this PR first & move the TODOs in #54

fix: use unified path & SSRF SEC problem
@imbajin imbajin changed the title refact: improve the graph rag experience refact: improve the graph rag config experience Jul 3, 2024
@imbajin imbajin marked this pull request as ready for review July 3, 2024 06:49
@dosubot dosubot Bot added the enhancement New feature or request label Jul 3, 2024
@imbajin imbajin requested a review from liuxiaocs7 July 3, 2024 06:49
@imbajin imbajin changed the title refact: improve the graph rag config experience refact: support py 3.12 & improve the graph rag config experience Jul 3, 2024
Copy link
Copy Markdown
Member

@liuxiaocs7 liuxiaocs7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@liuxiaocs7 liuxiaocs7 merged commit a805bb2 into main Jul 3, 2024
@liuxiaocs7 liuxiaocs7 deleted the rag branch July 3, 2024 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation enhancement New feature or request llm size:M This PR changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants