Conversation
Linary
force-pushed
the
closeness
branch
5 times, most recently
from
a777aeb to
c0beafd
Compare
Codecov Report
@@ Coverage Diff @@
## master #104 +/- ##
============================================
- Coverage 87.50% 87.35% -0.16%
- Complexity 2933 2988 +55
============================================
Files 308 314 +6
Lines 10999 11195 +196
Branches 941 964 +23
============================================
+ Hits 9625 9779 +154
- Misses 929 957 +28
- Partials 445 459 +14
Continue to review full report at Codecov.
|
javeme
reviewed
Oct 14, 2021
javeme
reviewed
Oct 14, 2021
javeme
reviewed
Oct 14, 2021
Comment on lines
+82
to
+88
| for (int i = 0; i < size; i++) { | ||
| Id id = this.graphFactory.createId(); | ||
| id.read(in); | ||
| Value<?> value = this.graphFactory.createValue(ValueType.DOUBLE); | ||
| value.read(in); | ||
| this.map.put(id, (DoubleValue) value); | ||
| } |
Contributor
There was a problem hiding this comment.
let ClosenessValue extend MapValue, or just use MapValue class?
javeme
reviewed
Oct 15, 2021
Linary
force-pushed
the
closeness
branch
2 times, most recently
from
353e56a to
e6be433
Compare
javeme
previously approved these changes
Oct 15, 2021
coderzc
requested changes
Oct 27, 2021
| } | ||
|
|
||
| @Override | ||
| public Object object() { |
coderzc
requested changes
Oct 28, 2021
| * until any queue is available | ||
| */ | ||
| if (emptyQueueCount >= channelCount) { | ||
| LOG.info("The send executor was blocked " + |
Contributor
Author
There was a problem hiding this comment.
It will lead too many print info
Contributor
There was a problem hiding this comment.
will not lead too many print info?
| * until any client is available | ||
| */ | ||
| if (busyClientCount >= channelCount) { | ||
| LOG.info("The send executor was blocked " + |
Contributor
Author
There was a problem hiding this comment.
It will lead too many print info
coderzc
requested changes
Oct 28, 2021
javeme
reviewed
Oct 29, 2021
Comment on lines
+40
to
+44
| MapValue<DoubleValue> localValue = vertex.value(); | ||
| // Cumulative distance | ||
| double centrality = 0; | ||
| for (Map.Entry<Id, DoubleValue> entry : localValue.entrySet()) { | ||
| centrality += 1.0D / entry.getValue().value(); |
Contributor
Author
There was a problem hiding this comment.
What mean? Move the for-loop logic into string() method?
Contributor
There was a problem hiding this comment.
I mean try to let ClosenessCentralityValue extends MapValue, move this block to ClosenessCentralityValue.value()/string(), and delete ClosenessCentralityLogOutput since LimitedLogOutput can log through ClosenessCentralityValue.string()
javeme
reviewed
Nov 15, 2021
| * until any queue is available | ||
| */ | ||
| if (emptyQueueCount >= channelCount) { | ||
| LOG.info("The send executor was blocked " + |
Contributor
There was a problem hiding this comment.
will not lead too many print info?
| .put("F", 1.45) | ||
| .build(); | ||
|
|
||
| public Vertex constructHugeVertex( |
Contributor
There was a problem hiding this comment.
override value() method instead
| .put("F", 3.333333333333333) | ||
| .build(); | ||
|
|
||
| public Vertex constructHugeVertex( |
Comment on lines
+40
to
+44
| MapValue<DoubleValue> localValue = vertex.value(); | ||
| // Cumulative distance | ||
| double centrality = 0; | ||
| for (Map.Entry<Id, DoubleValue> entry : localValue.entrySet()) { | ||
| centrality += 1.0D / entry.getValue().value(); |
Contributor
There was a problem hiding this comment.
I mean try to let ClosenessCentralityValue extends MapValue, move this block to ClosenessCentralityValue.value()/string(), and delete ClosenessCentralityLogOutput since LimitedLogOutput can log through ClosenessCentralityValue.string()
Linary
force-pushed
the
closeness
branch
3 times, most recently
from
b712b05 to
92d9c53
Compare
javeme
approved these changes
Dec 13, 2021
imbajin
approved these changes
Dec 13, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.