Skip to content

Pipe: Fixed the bug that Disruptor may not clear the reference & will wait long time after pipe close#17549

Open
Caideyipi wants to merge 2 commits intomasterfrom
disruptor
Open

Pipe: Fixed the bug that Disruptor may not clear the reference & will wait long time after pipe close#17549
Caideyipi wants to merge 2 commits intomasterfrom
disruptor

Conversation

@Caideyipi
Copy link
Copy Markdown
Collaborator

@Caideyipi Caideyipi commented Apr 27, 2026

Description

Before this PR, an empty realtime pipe may consume lots of time to close. The PR has checked the circumstance, where the pipe can be directly dropped now.


This PR has:

  • been self-reviewed.
    • concurrent read
    • concurrent write
    • concurrent read and write
  • added documentation for new or modified features or behaviors.
  • added Javadocs for most classes and all non-trivial methods.
  • added or updated version, license, or notice information
  • added comments explaining the "why" and the intent of the code wherever would not be obvious
    for an unfamiliar reader.
  • added unit tests or modified existing tests to cover new code paths, ensuring the threshold
    for code coverage.
  • added integration tests.
  • been tested in a test IoTDB cluster.

Key changed/added classes (or packages if there are too many classes) in this PR

@sonarqubecloud
Copy link
Copy Markdown

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 27, 2026

Codecov Report

❌ Patch coverage is 85.10638% with 7 lines in your changes missing coverage. Please review.
✅ Project coverage is 39.84%. Comparing base (859c719) to head (6d591e9).
⚠️ Report is 3 commits behind head on master.

Files with missing lines Patch % Lines
...region/realtime/disruptor/BatchEventProcessor.java 82.14% 5 Missing ⚠️
...ource/dataregion/realtime/disruptor/Disruptor.java 66.66% 1 Missing ⚠️
...altime/listener/PipeInsertionDataNodeListener.java 93.33% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##             master   #17549   +/-   ##
=========================================
  Coverage     39.83%   39.84%           
  Complexity     2539     2539           
=========================================
  Files          5171     5171           
  Lines        348095   348123   +28     
  Branches      44474    44480    +6     
=========================================
+ Hits         138677   138710   +33     
+ Misses       209418   209413    -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant