Skip to content

Introduce AllGroupHeadsCollectorManager#15565

Open
gaobinlong wants to merge 3 commits intoapache:mainfrom
gaobinlong:allGroupHeads
Open

Introduce AllGroupHeadsCollectorManager#15565
gaobinlong wants to merge 3 commits intoapache:mainfrom
gaobinlong:allGroupHeads

Conversation

@gaobinlong
Copy link
Copy Markdown
Contributor

Description

AllGroupHeadsCollectorManager in grouping package did not have until now a corresponding collector manager, this pr introduces one and switches TestAllGroupHeadsCollector to use search concurrency and move away from the deprecated search(Query, Collector) method.

Relates to #12892.

Signed-off-by: Binlong Gao <gbinlong@amazon.com>
Signed-off-by: Binlong Gao <gbinlong@amazon.com>
@github-actions github-actions bot added this to the 11.0.0 milestone Jan 13, 2026
Signed-off-by: Binlong Gao <gbinlong@amazon.com>
@github-actions
Copy link
Copy Markdown
Contributor

This PR has not had activity in the past 2 weeks, labeling it as stale. If the PR is waiting for review, notify the dev@lucene.apache.org list. Thank you for your contribution!

@github-actions github-actions bot added the Stale label Jan 28, 2026
@javanna
Copy link
Copy Markdown
Contributor

javanna commented Apr 13, 2026

Thanks for opening this PR @gaobinlong ! I had a quick look and my observations are similar to those I had at #15557 (comment) . We are introducing a new public collector manager that is only used in tests code, while the grouping collector code (GroupingSearch) requires some rework to rely on collector managers. I wonder if we should start with working on that, which looks though involving, or simply update the test so that it no longer relies on a collector manager.

All in all an important longer term question is how are grouping users going to move from collectors to collector managers. Lucene should probably include the building blocks for them to do so, and we need to define which those are.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants