Skip to content
This repository was archived by the owner on Nov 17, 2023. It is now read-only.
This repository was archived by the owner on Nov 17, 2023. It is now read-only.

Multi-threaded inferencing support now lacking a unittest? #19082

@DickJC123

Description

@DickJC123

While we generally insist that a new feature come with unittests at time of introduction, it's also important to ensure those tests are not removed or marked 'skipped' for too long to protect the feature from falling into disrepair.

Back in February, @anirudh2290's PR #16654 introduced multi-threaded inferencing, with new files ./src/imperative/cached_op_threadsafe.{h,cc} and a unittest under ./tests/cpp/thread_safety/. However in June, @eric-haibin-lin's PR #18598 "graph executor c api removal" removed the test files, but left the cached_op_threadsafe.{h,cc} files. Is there some other unittest of multi-threaded inferencing, and with which front end? If not, can the old test be reinstated or replaced?

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions