This repository was archived by the owner on Nov 17, 2023. It is now read-only.
Closed
Conversation
marcoabreu
suggested changes
Jun 15, 2018
|
|
||
| bool match = SetForwardGraph(&state.info, recording, inputs); | ||
| match = match && state.recording != recording; | ||
| match = match && state.recording == recording; |
tqchen
approved these changes
Jun 15, 2018
Member
|
please add a regression test, or indicate the test case already covered by existing one(that results in flaky tests) |
Member
|
please bring in the new changes, and rebase against the master |
Member
|
replace by #10817 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
(Brief description on what this PR is about)
Checklist
Essentials
Please feel free to remove inapplicable items for your PR.
Changes
Comments