Skip to content
This repository was archived by the owner on Nov 17, 2023. It is now read-only.

Update cached_op.cc#11310

Closed
piiswrong wants to merge 2 commits intomasterfrom
piiswrong-patch-3
Closed

Update cached_op.cc#11310
piiswrong wants to merge 2 commits intomasterfrom
piiswrong-patch-3

Conversation

@piiswrong
Copy link
Copy Markdown
Contributor

Description

(Brief description on what this PR is about)

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
  • Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
  • Code is well-documented:
  • For user-facing API changes, API doc string has been updated.
  • For new C++ functions in header files, their functionalities and arguments are documented.
  • For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
  • Check the API doc at http://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
  • To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

  • Feature1, tests, (and when applicable, API doc)
  • Feature2, tests, (and when applicable, API doc)

Comments

  • If this change is a backward incompatible change, why must this change be made.
  • Interesting edge cases to note here


bool match = SetForwardGraph(&state.info, recording, inputs);
match = match && state.recording != recording;
match = match && state.recording == recording;
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test?

@tqchen
Copy link
Copy Markdown
Member

tqchen commented Jun 15, 2018

please add a regression test, or indicate the test case already covered by existing one(that results in flaky tests)

@tqchen
Copy link
Copy Markdown
Member

tqchen commented Jun 15, 2018

please bring in the new changes, and rebase against the master

@tqchen
Copy link
Copy Markdown
Member

tqchen commented Jun 15, 2018

replace by #10817

@tqchen tqchen closed this Jun 15, 2018
@tqchen tqchen deleted the piiswrong-patch-3 branch June 16, 2018 02:06
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants