Skip to content
This repository was archived by the owner on Nov 17, 2023. It is now read-only.

Link fixes4#16764

Merged
iblislin merged 5 commits intoapache:masterfrom
TEChopra1000:link_fixes4
Nov 13, 2019
Merged

Link fixes4#16764
iblislin merged 5 commits intoapache:masterfrom
TEChopra1000:link_fixes4

Conversation

@TEChopra1000
Copy link
Copy Markdown
Contributor

@TEChopra1000 TEChopra1000 commented Nov 8, 2019

A new round of link fixes.

iblislin
iblislin approved these changes Nov 9, 2019
View reviewed changes
Copy link
Copy Markdown
Member

@iblislin iblislin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Julia part is fine for me. 👍

iblislin
iblislin reviewed Nov 9, 2019
View reviewed changes
Comment thread julia/docs/src/tutorial/char-lstm.md Outdated
We will be using fixed-length input sequence for training. The code is
adapted from the [char-rnn example for MXNet's Python
binding](https://github.com/dmlc/mxnet-notebooks/blob/master/python/tutorials/char_lstm.ipynb),
binding](/api/r/docs/tutorials/char_rnn_model),
Copy link
Copy Markdown
Member

@iblislin iblislin Nov 9, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah, is there a Python tutorial on the web site?

Copy link
Copy Markdown
Contributor Author

@TEChopra1000 TEChopra1000 Nov 9, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@iblis17 there is this one: https://mxnet.apache.org/api/r/docs/tutorials/char_rnn_model.

Copy link
Copy Markdown
Member

@iblislin iblislin Nov 9, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

well, I think it's R's, not Python.

Copy link
Copy Markdown
Contributor Author

@TEChopra1000 TEChopra1000 Nov 9, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah I overlooked that. What about this? https://github.com/apache/incubator-mxnet/blob/8004a027ad6a73f8f6eae102de8d249fbdfb9a2d/example/rnn/old/char-rnn.ipynb

Copy link
Copy Markdown
Member

@iblislin iblislin Nov 10, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, nice, that's the correct one.

TEChopra1000
TEChopra1000 commented Nov 9, 2019
View reviewed changes
Comment thread docs/python_docs/python/tutorials/index.rst Outdated
TEChopra1000
TEChopra1000 commented Nov 11, 2019
View reviewed changes
Copy link
Copy Markdown
Contributor Author

@TEChopra1000 TEChopra1000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed site-link for python char-rnn tutorial.

Comment thread julia/docs/src/tutorial/char-lstm.md Outdated
@ChaiBapchya
Copy link
Copy Markdown
Contributor

ChaiBapchya commented Nov 11, 2019 •
edited
Loading

@aaronmarkham @TEChopra1000
The reason why you were facing MKLDNN lib error was
Your branch was likely not updated with latest master

Your error - MKLDNN lib not found - #16629
Fixed in this PR - #16690
Needs to be included in your branch.

Steps to merge

git remote add upstream https://github.com/apache/incubator-mxnet

git checkout master
git fetch upstream master
git merge upstream/master
git push origin master

This updates your master
Now update your feature branch

git checkout <branchname>
git merge master
git push origin <branchname>

Hope this helps.

@TEChopra1000
Copy link
Copy Markdown
Contributor Author

TEChopra1000 commented Nov 13, 2019

@aaronmarkham would you be willing to merge these link fixes?

ChaiBapchya
ChaiBapchya approved these changes Nov 13, 2019
View reviewed changes
Copy link
Copy Markdown
Contributor

@ChaiBapchya ChaiBapchya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's get this merged!

@iblislin iblislin merged commit 47fd3a0 into apache:master Nov 13, 2019
@TEChopra1000 TEChopra1000 deleted the link_fixes4 branch December 2, 2019 22:14
ys2843
ys2843 reviewed Jun 19, 2020
View reviewed changes
Comment thread docs/python_docs/python/tutorials/getting-started/gluon_from_experiment_to_deployment.md

Here we will briefly introduce how to run inference using Module API in Python. There is more detailed explanation available in the [Predict Image Tutorial](https://mxnet.apache.org/tutorials/python/predict_image.html).
In general, prediction consists of the following steps:
Here we will briefly introduce how to run inference using Module API in Python. In general, prediction consists of the following steps:
Copy link
Copy Markdown
Contributor

@ys2843 ys2843 Jun 19, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the broken link discussed in #16724

Copy link
Copy Markdown
Contributor

@ChaiBapchya ChaiBapchya Jun 19, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you want to add it back? or the image-classification shouldn't exist anymore? What's the solution for that issue?

Copy link
Copy Markdown
Contributor

@ys2843 ys2843 Jun 19, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ChaiBapchya #16724 is still open, I wondered if something is pending. I personally don't know the expect solution, if everything is good we can close it.

But following link was mentioned in the issue, not sure if this need to be considered.

True link should be -- https://github.com/dmlc/mxnet-notebooks/blob/master/python/tutorials/predict_imagenet.ipynb

Copy link
Copy Markdown
Contributor

@ChaiBapchya ChaiBapchya Jun 20, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see there was a link which previously existed. Now the link has been removed. Have a word with Aaron/Talia they have a better idea.

@ys2843 ys2843 mentioned this pull request Jun 19, 2020
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@aaronmarkham aaronmarkham Awaiting requested review from aaronmarkham aaronmarkham is a code owner

@szha szha Awaiting requested review from szha szha is a code owner

3 more reviewers

@iblislin iblislin iblislin approved these changes

@ChaiBapchya ChaiBapchya ChaiBapchya approved these changes

@ys2843 ys2843 ys2843 left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@TEChopra1000 @ChaiBapchya @iblislin @ys2843