Skip to content
This repository was archived by the owner on Nov 17, 2023. It is now read-only.

Back port the PR #17672:boolean indexing to branch v1.7.x#18352

Merged
TaoLv merged 1 commit intoapache:v1.7.xfrom
Alicia1529:v1.7.x_backport_17672
May 28, 2020
Merged

Back port the PR #17672:boolean indexing to branch v1.7.x#18352
TaoLv merged 1 commit intoapache:v1.7.xfrom
Alicia1529:v1.7.x_backport_17672

Conversation

@Alicia1529
Copy link
Copy Markdown
Contributor

@Alicia1529 Alicia1529 commented May 18, 2020

Back port the PR #17672:boolean indexing from master to branch v1.7.x

@ciyongch

@Alicia1529 Alicia1529 requested a review from szha as a code owner May 18, 2020 11:51
@mxnet-bot
Copy link
Copy Markdown

mxnet-bot commented May 18, 2020

Hey @Alicia1529 , Thanks for submitting the PR
All tests are already queued to run once. If tests fail, you can trigger one or more tests again with the following commands:

  • To trigger all jobs: @mxnet-bot run ci [all]
  • To trigger specific jobs: @mxnet-bot run ci [job1, job2]

CI supported jobs: [website, windows-gpu, miscellaneous, unix-gpu, centos-gpu, unix-cpu, sanity, edge, windows-cpu, centos-cpu, clang]

Note:
Only following 3 categories can trigger CI :PR Author, MXNet Committer, Jenkins Admin.
All CI tests must pass before the PR can be merged.

@Alicia1529
Copy link
Copy Markdown
Contributor Author

Alicia1529 commented May 19, 2020

@mxnet-bot run ci [clang, edge, miscellaneous, unix-cpu, unix-gpu, windows-cpu]

@mxnet-bot
Copy link
Copy Markdown

mxnet-bot commented May 19, 2020

Jenkins CI successfully triggered : [clang, unix-gpu, windows-cpu, miscellaneous, unix-cpu, edge]

@ciyongch
Copy link
Copy Markdown
Contributor

ciyongch commented May 21, 2020

Hi @Alicia1529 , please re-trigger the failed CI, thanks!

@Alicia1529
Copy link
Copy Markdown
Contributor Author

Alicia1529 commented May 21, 2020

@mxnet-bot run ci [clang, edge, miscellaneous, unix-cpu, unix-gpu]

@mxnet-bot
Copy link
Copy Markdown

mxnet-bot commented May 21, 2020

Jenkins CI successfully triggered : [miscellaneous, clang, unix-cpu, unix-gpu, edge]

@Alicia1529
Copy link
Copy Markdown
Contributor Author

Alicia1529 commented May 21, 2020

@mxnet-bot run ci [edge, unix-gpu]

@mxnet-bot
Copy link
Copy Markdown

mxnet-bot commented May 21, 2020

Jenkins CI successfully triggered : [unix-gpu, edge]

@Alicia1529
Copy link
Copy Markdown
Contributor Author

Alicia1529 commented May 21, 2020

@mxnet-bot run ci [edge]

@mxnet-bot
Copy link
Copy Markdown

mxnet-bot commented May 21, 2020

Jenkins CI successfully triggered : [edge]

@Alicia1529
Copy link
Copy Markdown
Contributor Author

Alicia1529 commented May 22, 2020

@mxnet-bot run ci [edge]

@mxnet-bot
Copy link
Copy Markdown

mxnet-bot commented May 22, 2020

Jenkins CI successfully triggered : [edge]

@Alicia1529
Copy link
Copy Markdown
Contributor Author

Alicia1529 commented May 22, 2020

@mxnet-bot run ci [edge]

@mxnet-bot
Copy link
Copy Markdown

mxnet-bot commented May 22, 2020

Jenkins CI successfully triggered : [edge]

@Alicia1529
Copy link
Copy Markdown
Contributor Author

Alicia1529 commented May 22, 2020

@mxnet-bot run ci [edge]

@mxnet-bot
Copy link
Copy Markdown

mxnet-bot commented May 22, 2020

Jenkins CI successfully triggered : [edge]

@Alicia1529
Copy link
Copy Markdown
Contributor Author

Alicia1529 commented May 22, 2020

@mxnet-bot run ci [edge]

@mxnet-bot
Copy link
Copy Markdown

mxnet-bot commented May 22, 2020

Jenkins CI successfully triggered : [edge]

@Alicia1529
Copy link
Copy Markdown
Contributor Author

Alicia1529 commented May 23, 2020

@mxnet-bot run ci [edge]

@mxnet-bot
Copy link
Copy Markdown

mxnet-bot commented May 23, 2020

Jenkins CI successfully triggered : [edge]

@Alicia1529
Copy link
Copy Markdown
Contributor Author

Alicia1529 commented May 23, 2020

@mxnet-bot run ci [edge]

@mxnet-bot
Copy link
Copy Markdown

mxnet-bot commented May 23, 2020

Jenkins CI successfully triggered : [edge]

@Alicia1529
Copy link
Copy Markdown
Contributor Author

Alicia1529 commented May 24, 2020

@mxnet-bot run ci [edge]

@mxnet-bot
Copy link
Copy Markdown

mxnet-bot commented May 24, 2020

Jenkins CI successfully triggered : [edge]

@ciyongch
Copy link
Copy Markdown
Contributor

ciyongch commented May 27, 2020

Hi @Alicia1529 , PR #18339 to address the edge job failure was merged into v1.7.x branch. Please help to re-trigger the edge job which is supposed to be passed now.

@leezu
Copy link
Copy Markdown
Contributor

leezu commented May 27, 2020

@mxnet-bot run ci [edge]

@mxnet-bot
Copy link
Copy Markdown

mxnet-bot commented May 27, 2020

Jenkins CI successfully triggered : [edge]

@Alicia1529
Copy link
Copy Markdown
Contributor Author

Alicia1529 commented May 28, 2020

Hi @ciyongch, this pr has passed all the tests and is ready to be merged.

@ciyongch
Copy link
Copy Markdown
Contributor

ciyongch commented May 28, 2020

Thanks @Alicia1529 , ping @TaoLv @pengzhao-intel @leezu to help merge.

@TaoLv TaoLv merged commit 75ab155 into apache:v1.7.x May 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@szha szha Awaiting requested review from szha szha is a code owner

1 more reviewer

@TaoLv TaoLv TaoLv approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@Alicia1529 @mxnet-bot @ciyongch @leezu @TaoLv