Skip to content
This repository was archived by the owner on Nov 17, 2023. It is now read-only.

[1.x] Backporting TensorRT-Gluon Partition API (and TensorRT 7 support)#18916

Merged
samskalicky merged 3 commits intoapache:v1.xfrom
Kh4L:backport_trt_gluon
Aug 19, 2020
Merged

[1.x] Backporting TensorRT-Gluon Partition API (and TensorRT 7 support)#18916
samskalicky merged 3 commits intoapache:v1.xfrom
Kh4L:backport_trt_gluon

Conversation

@Kh4L
Copy link
Copy Markdown
Contributor

@Kh4L Kh4L commented Aug 12, 2020

Description

Backported PRs (some of them are slightly modified to be compatible with v1.x):

@mxnet-bot
Copy link
Copy Markdown

mxnet-bot commented Aug 12, 2020

Hey @Kh4L , Thanks for submitting the PR
All tests are already queued to run once. If tests fail, you can trigger one or more tests again with the following commands:

  • To trigger all jobs: @mxnet-bot run ci [all]
  • To trigger specific jobs: @mxnet-bot run ci [job1, job2]

CI supported jobs: [windows-gpu, sanity, website, windows-cpu, miscellaneous, centos-cpu, unix-cpu, edge, unix-gpu, centos-gpu, clang]

Note:
Only following 3 categories can trigger CI :PR Author, MXNet Committer, Jenkins Admin.
All CI tests must pass before the PR can be merged.

@samskalicky samskalicky mentioned this pull request Aug 13, 2020
Open
@Kh4L
Copy link
Copy Markdown
Contributor Author

Kh4L commented Aug 13, 2020

@mxnet-bot run ci [edge, unix-cpu]

@mxnet-bot
Copy link
Copy Markdown

mxnet-bot commented Aug 13, 2020

Jenkins CI successfully triggered : [edge, unix-cpu]

@Kh4L Kh4L requested a review from marcoabreu as a code owner August 13, 2020 22:15
@Kh4L Kh4L force-pushed the backport_trt_gluon branch 3 times, most recently from 6ea1a01 to c0efbab Compare August 14, 2020 21:04
@Kh4L Kh4L requested a review from sergeykolychev as a code owner August 14, 2020 21:04
@Kh4L Kh4L force-pushed the backport_trt_gluon branch from c0efbab to 786bb35 Compare August 14, 2020 21:31
@Kh4L
Copy link
Copy Markdown
Contributor Author

Kh4L commented Aug 18, 2020

@mxnet-bot run ci [unix-cpu, unix-gpu]

@mxnet-bot
Copy link
Copy Markdown

mxnet-bot commented Aug 18, 2020

Jenkins CI successfully triggered : [unix-gpu, unix-cpu]

@Kh4L
Copy link
Copy Markdown
Contributor Author

Kh4L commented Aug 18, 2020

@mxnet-bot run ci [unix-gpu]

@mxnet-bot
Copy link
Copy Markdown

mxnet-bot commented Aug 18, 2020

Jenkins CI successfully triggered : [unix-gpu]

samskalicky
samskalicky reviewed Aug 18, 2020
View reviewed changes
Comment thread ci/jenkins/Jenkins_steps.groovy
}]
}

def test_unix_python3_tensorrt_gpu() {
Copy link
Copy Markdown
Contributor

@samskalicky samskalicky Aug 18, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mseth10 I guess this is the cause of the CI job issue

Copy link
Copy Markdown
Contributor

@samskalicky samskalicky Aug 18, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Kh4L you'd need to get rid of this too if you wanna remove this test:
https://github.com/apache/incubator-mxnet/blob/9981e847fff9270268385068c5b7d0c3929e46f9/ci/jenkins/Jenkinsfile_unix_gpu#L53
This is where its being called from, but since you deleted the function it doesnt exist. Hence the error in the log:
https://jenkins.mxnet-ci.amazon-ml.com/job/mxnet-validation/job/unix-gpu/view/change-requests/job/PR-18916/8/consoleText

[2020-08-18T07:58:59.886Z] java.lang.NoSuchMethodError: No such DSL method ‘test_unix_python3_tensorrt_gpu’

Copy link
Copy Markdown
Contributor

@mseth10 mseth10 Aug 18, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that's right, if we remove this test we should also remove it from jenkins pipeline

Copy link
Copy Markdown
Contributor

@mseth10 mseth10 Aug 18, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in master, it's removed in this commit
c1098aa#diff-0c2b22569b87fa79153336ea3ac94f33

Copy link
Copy Markdown
Contributor Author

@Kh4L Kh4L Aug 18, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for investigating, I missed that file...

Kh4L added 3 commits August 18, 2020 16:39
@Kh4L
[1.x] Backporting TensorRT and Gluon changes
02ccb5f 
Signed-off-by: Serge Panev <spanev@nvidia.com>
@Kh4L
Remove test from Jenkins
3511047 
Signed-off-by: Serge Panev <spanev@nvidia.com>
@Kh4L
Fix test
a62e081 
Signed-off-by: Serge Panev <spanev@nvidia.com>
@Kh4L Kh4L force-pushed the backport_trt_gluon branch from c40a2a4 to a62e081 Compare August 18, 2020 23:43
@samskalicky samskalicky merged commit 8dcc653 into apache:v1.x Aug 19, 2020
@szha szha added this to the v1.8.0 milestone Aug 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@aaronmarkham aaronmarkham Awaiting requested review from aaronmarkham aaronmarkham is a code owner

@anirudh2290 anirudh2290 Awaiting requested review from anirudh2290 anirudh2290 is a code owner

@eric-haibin-lin eric-haibin-lin Awaiting requested review from eric-haibin-lin eric-haibin-lin is a code owner

@szha szha Awaiting requested review from szha szha is a code owner

@marcoabreu marcoabreu Awaiting requested review from marcoabreu marcoabreu is a code owner

@sergeykolychev sergeykolychev Awaiting requested review from sergeykolychev sergeykolychev is a code owner

2 more reviewers

@samskalicky samskalicky samskalicky left review comments

@mseth10 mseth10 mseth10 left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

v1.8.0

Development

Successfully merging this pull request may close these issues.

5 participants

@Kh4L @mxnet-bot @samskalicky @mseth10 @szha