This repository was archived by the owner on Nov 17, 2023. It is now read-only.
Separate backend from hybridize and refactor optimize_for kwargs#19543
Merged
mseth10 merged 5 commits intoapache:masterfrom Nov 18, 2020
Merged
Separate backend from hybridize and refactor optimize_for kwargs#19543mseth10 merged 5 commits intoapache:masterfrom
mseth10 merged 5 commits intoapache:masterfrom
Conversation
Signed-off-by: Serge Panev <spanev@nvidia.com>
|
Hey @Kh4L , Thanks for submitting the PR
CI supported jobs: [website, windows-gpu, unix-cpu, clang, windows-cpu, sanity, centos-cpu, unix-gpu, edge, centos-gpu, miscellaneous] Note: |
mseth10
reviewed
Nov 17, 2020
mseth10
reviewed
Nov 17, 2020
mseth10
reviewed
Nov 17, 2020
Signed-off-by: Serge Panev <spanev@nvidia.com>
samskalicky
reviewed
Nov 17, 2020
samskalicky
reviewed
Nov 17, 2020
samskalicky
reviewed
Nov 17, 2020
Signed-off-by: Serge Panev <spanev@nvidia.com>
Contributor
Author
|
@samskalicky I updated the documentation to reflect the changes |
samskalicky
reviewed
Nov 17, 2020
samskalicky
reviewed
Nov 17, 2020
waytrue17
reviewed
Nov 17, 2020
waytrue17
approved these changes
Nov 18, 2020
Contributor
waytrue17
left a comment
There was a problem hiding this comment.
Thanks for the great work!
Contributor
Author
|
@mxnet-bot run ci [unix-cpu] |
|
Jenkins CI successfully triggered : [unix-cpu] |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR separates the partitioning backend from hybridize.
hybridizenow clears any previous optimization, sets the CachedOp args and activate the hybridization.optimize_foris responsible of setting the backend, backend options and running the partitioning with backend.If the user wish to use any partitioning backend, they have use optimize_for.
It also changes the default value of
optimize_for'scleararg, making the chaining of the backend the default behavior.The PR also make the CachedOp kwargs explicit and documented :
static_alloc, static_shape, inline_limit, forward_bulk_size, backward_bulk_size.Examples
How optimize_for changed
Before
After
How hybridize changed
Before
After
Hybridize can't be used to set the backend anymore, we now have to use
optimize_for, which will call hybridize internally.How chaining backends changed
Before
After
cleardefault value isFalse, we simply chain themcc @samskalicky who helped to design the API offline and reviewed the
1.xrelated PR #19386@mseth10 who helped by reviewing the
1.xPR