Fixed: Ensure that the invoice item quantity is set to 1 only if the quantity is null when invoice items are created by the createInvoiceItem service (OFBIZ-13362)#963
Merged
jacopoc merged 1 commit intoapache:trunkfrom Apr 5, 2026
Conversation
…y is null when invoice items are created by the createInvoiceItem service
|
Contributor
|
@golja it would be great if you could provide a PR to backport this fix to release24.09 (in preparation for the upcoming release 24.09.06). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR solves the first issue described in OFBIZ-13362
When the system creates a receipt with an accepted quantity equal to zero, the service createInvoiceItem erroneously set the item invoice quantity to 1, leading to a wrong invoiced quantity.
The change in the PR makes sure that only quantities equal to null are set to 1.