Add POST /tableConfigs/tune endpoint to apply tuning and return tuned config#18056
Open
rseetham wants to merge 1 commit intoapache:masterfrom
Open
Add POST /tableConfigs/tune endpoint to apply tuning and return tuned config#18056rseetham wants to merge 1 commit intoapache:masterfrom
rseetham wants to merge 1 commit intoapache:masterfrom
Conversation
…igs and returns the tuned config.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #18056 +/- ##
============================================
+ Coverage 63.34% 63.35% +0.01%
+ Complexity 1543 1540 -3
============================================
Files 3200 3200
Lines 194222 194237 +15
Branches 29934 29931 -3
============================================
+ Hits 123026 123065 +39
+ Misses 61526 61509 -17
+ Partials 9670 9663 -7
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is this PR doing / why is it needed?
The existing
POST /tableConfigs/validateendpoint validates the providedTableConfigsand returns the input as-is (modulo database name translation). However, the actual create (POST /tableConfigs) and update (PUT /tableConfigs/{tableName}) paths apply additional tuning before persisting:realtimeAutoIndexTuner)This means callers have no way to preview what would actually be stored without performing the real operation.
This PR adds a new
POST /tableConfigs/tuneendpoint that validates theTableConfigsand then applies the same tuning as create/update, returning the resulting config. This lets callers preview the final tuned config before committing.Changes
POST /tableConfigs/tuneendpoint inTableConfigsRestletResourceparseAndValidateTableConfigshelper, used by bothvalidateandtuneendpointstuneConfig(TableConfig, Schema)helper toapplyTuningto avoid name collision with the new public endpoint methodforTableConfigsTune()toControllerRequestURLBuildertestTuneConfigtest inTableConfigsRestletResourceTestcovering: invalid input, min replicas, dim table quota, tuner config application, and unrecognized properties passthroughTesting Done
All existing
TableConfigsRestletResourceTesttests pass. NewtestTuneConfigtest added and passing.