RATIS-2073. Enable Surefire process checkers#1079
Merged
adoroszlai merged 1 commit intoapache:masterfrom May 6, 2024
Merged
Conversation
szetszwo
approved these changes
May 6, 2024
Contributor
szetszwo
left a comment
szetszwo
left a comment
There was a problem hiding this comment.
+1 the change looks good.
Contributor
Author
|
Thanks @szetszwo for the review. |
SzyWilliam
pushed a commit
that referenced
this pull request
Jun 12, 2024
szetszwo
pushed a commit
to szetszwo/ratis
that referenced
this pull request
Jun 16, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Ratis build sets Surefire fork timeout to 10 minutes:
ratis/pom.xml
Line 637 in 5867192
Yet, sometimes Surefire fork is not killed, check runs until Github workflow is cancelled:
The problem is that:
Changes in this PR (and links to similar change in Ozone):
https://issues.apache.org/jira/browse/RATIS-2073
How was this patch tested?
Created a small repro to test various Surefire versions, see apache/ozone#6075 for details.
Regular CI:
https://github.com/adoroszlai/ratis/actions/runs/8972109715