RATIS-2074. Intermittent fork timeout in TestRaftWithNetty#testBasicAppendEntriesKillLeader.#1080
Conversation
…ppendEntriesKillLeader.
|
@adoroszlai , could you test if this could fix the problem? |
There was a problem hiding this comment.
Thanks @szetszwo for the patch.
Tried 100 runs with it:
- RATIS-2074 did not happen
- RATIS-2076 happened in 6 runs (about the same rate as previously)
Failed to close channel localhost:... in 10s appears in 2 runs:
- split 7 iteration 5
- split 9 iteration 1
It may have appeared in successful runs, too, but those logs are not kept.
testBasicAppendEntriesKillLeader is successful even if channel cannot be closed.
So the patch fixes the fork timeout.
Both cases seem okay
|
There were 300 threads running. I suspect the failures was due to slowness. Let's try increasing the timeout. |
Only 1/100 runs failed with 63490ea: |
|
@adoroszlai , thanks for testing and reviewing this! Let's merge this PR first. We can continue fixing the remaining problem on RATIS-2076. |
…ppendEntriesKillLeader. (#1080)
…ppendEntriesKillLeader. (apache#1080)
See RATIS-2074