RATIS-2497. Implement dummy request as a noop request instead of watch request#1433
Closed
ivandika3 wants to merge 3 commits intoapache:masterfrom
Closed
RATIS-2497. Implement dummy request as a noop request instead of watch request#1433ivandika3 wants to merge 3 commits intoapache:masterfrom
ivandika3 wants to merge 3 commits intoapache:masterfrom
Conversation
Contributor
Author
|
Closing this, I think it's better to address this TODO. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Currently the dummy request is a WATCH(0) which will trigger client leader failover. In a follower read client scenario, this might cause client to always failover to the leader which reduces the follower read effectiveness.
We can try implement a new noop request (some kind of ping request) which simply returns a successful response regardless of the Raft peer role.
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/RATIS-2497
How was this patch tested?
UT.