TOMEE-4460 - Fix Missing service-jar.xml in Serverless Builder and Embedded Scenarios#1804
Merged
TOMEE-4460 - Fix Missing service-jar.xml in Serverless Builder and Embedded Scenarios#1804
Conversation
tomee-config.jar, as we no longer deploy web applications (.jar/.war). With the recent fix in BOM generation, the service-jar.xml file is now missing in embedded and server builder scenarios. This change ensures it is correctly included.
… modules. Clean up unnecessary code and switch packaging from WAR to ZIP. Set the POM type to "pom".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The recent removal of webapps from the assembly process led to the service-jar.xml file being omitted from BOMs, breaking serverless builder examples. This occurred because the file was previously included via webapps, which are no longer deployed and therefore no longer part of the BOMs. Since the JARs were added to the /lib folder of TomEE regardless, this does not happen for arquillian or real world cases.
This PR makes the following changes:
Build: https://ci-builds.apache.org/job/Tomee/job/pull-request-manual/158
Note: Build uses Tomcat Snapshot due to their attempt to fix a CVE breaking Embedded Case since 10.1.34+