Conversation
Member
Author
|
Concurrency TCK still passing locally, full build with TCK is running here: https://ci-builds.apache.org/job/Tomee/view/tomee-10.x/job/pull-request-manual-with-tck/30/ |
Contributor
|
This looks good to me. I've rebased it. +1 to merge. |
jgallimore
approved these changes
Sep 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See TOMEE-4518 and this thread on the dev list
Maybe we should think out loud about failing the deployment of a
ContextServiceif it definesPropagated*=Transaction. This however brings up questions again like what to do in this case:And if we should completely abort the TomEE startup if an illegal ContextService is detected in
tomee.xml. What if it hasLazy=true? So I chose to not enforce this via code yet.