fix: return 'invalid' from Level.String instead of panicking on InvalidLevel#119
Open
SAY-5 wants to merge 1 commit intoapex:masterfrom
Open
fix: return 'invalid' from Level.String instead of panicking on InvalidLevel#119SAY-5 wants to merge 1 commit intoapex:masterfrom
SAY-5 wants to merge 1 commit intoapex:masterfrom
Conversation
…idLevel Level.String indexed levelNames directly, which is a fixed array keyed by the DebugLevel..FatalLevel block. An InvalidLevel value (-1, e.g. from a zero-value pointer or a failed ParseLevel that the caller did not error-check) therefore sliced levelNames[-1] and produced 'index out of range'. MarshalJSON wraps String, so any JSON encoder touching a Level field that was never explicitly set crashes the host process instead of surfacing a useful error (apex#75). Bounds-check l against the valid Debug..Fatal span and return 'invalid' for anything outside it. Valid Debug..Fatal values keep their existing names byte-for-byte. Closes apex#75 Signed-off-by: SAY-5 <SAY-5@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Fixes #75.
Level.StringindexedlevelNamesdirectly - a fixed array keyed by theDebugLevel..FatalLevelblock. AnInvalidLevelvalue (-1, e.g. from a zero-value pointer or a failedParseLevelthat the caller did not error-check) therefore slicedlevelNames[-1]and produced:MarshalJSONwrapsString, so any JSON encoder touching aLevelfield that was never explicitly set crashes the host process instead of surfacing a useful error.Fix
Bounds-check
lagainst the validDebug..Fatalspan and return"invalid"for anything outside it. ValidDebug..Fatalvalues keep their existing names byte-for-byte.Verification
Locally on macOS, go 1.26.2:
gofmt -s -l levels.go: cleango vet ./...: cleango test -race -count=1 ./...: pass across all handlersCloses #75