fix: cap _list_head request limit at _MAX_HEAD_ITEMS#869
Merged
Conversation
`_list_head` used `max` instead of `min` when sizing its `list_head` request, which both over-fetched in the common case and exceeded the documented API cap of 1000 once in-progress requests passed 800. Switching to `min` restores the intended pad-then-cap behavior.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #869 +/- ##
==========================================
+ Coverage 86.64% 86.67% +0.03%
==========================================
Files 48 48
Lines 2920 2920
==========================================
+ Hits 2530 2531 +1
+ Misses 390 389 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Pijukatel
approved these changes
Apr 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ApifyRequestQueueSingleClient._list_headusedmaxinstead ofminwhen computing thelimitpassed to the Apify API:Two problems with this:
desired + in_progress < 1000,maxforces the limit to 1000, pulling up to 5× more items than the logic actually wants (e.g. 1000 instead of 200 on a fresh queue).len(self._requests_in_progress) > 800, the sum exceeds_MAX_HEAD_ITEMS = 1000andmaxpicks that larger value as thelimit, violating the documented API cap.The comment on the preceding line describes the intended "pad, then cap" behavior — the code should pad by in-progress count and then cap at the API maximum. Fix is one character:
max→min.Added three parametrized regression cases covering no-in-progress, mid-queue padding, and the cap boundary.