fix: preserve max_total_charge_usd=0 instead of treating it as unlimited#870
Merged
fix: preserve max_total_charge_usd=0 instead of treating it as unlimited#870
max_total_charge_usd=0 instead of treating it as unlimited#870Conversation
…mited
`Decimal(0) or Decimal('inf')` evaluates to `Decimal('inf')` because
`Decimal(0)` is falsy, silently inverting the user's intent when `0` is
explicitly set as a kill-switch. Replace with an explicit `is not None`
check at the three affected sites, matching the correct pattern already
used on the API-fetch path.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
vdusek
added
adhoc
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #870 +/- ##
=======================================
Coverage 86.64% 86.64%
=======================================
Files 48 48
Lines 2920 2920
=======================================
Hits 2530 2530
Misses 390 390
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Pijukatel
approved these changes
Apr 20, 2026
Contributor
Pijukatel
left a comment
Pijukatel
left a comment
There was a problem hiding this comment.
Good catch, I think this deserves a test.
Add two regression tests matching the three fix sites in
`ChargingManagerImplementation`:
- with PPE pricing env vars set, `max_total_charge_usd=0` blocks all
charging (exercises `__init__` + the env-var `_fetch_pricing_info`
path).
- without pricing, the zero value is still preserved through the
fallback path.
Both would have failed before the fix (the `or Decimal('inf')`
coalescence silently promoted `Decimal(0)` to unlimited).
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
github-actions
Bot
added
the
tested
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
configuration.max_total_charge_usd or Decimal('inf')atsrc/apify/_charging.py:162,:416, and:439treatsDecimal(0)as falsy and silently replaces it withDecimal('inf'). A user who explicitly setsmax_total_charge_usd=0(orACTOR_MAX_TOTAL_CHARGE_USD=0) to disable charging ends up with unlimited charging — the opposite of the intended behavior.The configuration layer already preserves
0as a distinct value (andtest_max_total_charge_usd_zero_is_preservedasserts this), so the invariant is thrown away only at the charging manager boundary.Replaced the three occurrences with an explicit
… if … is not None else Decimal('inf')check, matching the already-correct pattern used on the API-fetch path (line 438).🤖 Generated with Claude Code