Skip to content

test: replace fixed sleep with poll_until_condition in test_cache_initialization #882

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vdusek merged 1 commit into from
Apr 29, 2026
+11 −5
Merged

test: replace fixed sleep with poll_until_condition in test_cache_initialization #882

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 11 additions & 5 deletions tests/integration/test_request_queue.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -986,9 +986,13 @@ async def test_cache_initialization(apify_token: str, monkeypatch: pytest.Monkey
try:
await rq.add_requests(requests)

# Check that it is correctly in the API
await asyncio.sleep(10) # Wait to be sure that metadata are updated
metadata = cast('ApifyRequestQueueMetadata', await rq.get_metadata())
async def _get_rq_metadata() -> ApifyRequestQueueMetadata:
return cast('ApifyRequestQueueMetadata', await rq.get_metadata())

metadata = await poll_until_condition(
_get_rq_metadata,
lambda m: m.stats.write_count >= len(requests),
)
stats_before = metadata.stats
Actor.log.info(stats_before)

Expand All @@ -999,8 +1003,10 @@ async def test_cache_initialization(apify_token: str, monkeypatch: pytest.Monkey
rq = await Actor.open_request_queue(name=request_queue_name, force_cloud=True)
await rq.add_requests(requests)

await asyncio.sleep(10) # Wait to be sure that metadata are updated
metadata = cast('ApifyRequestQueueMetadata', await rq.get_metadata())
metadata = await poll_until_condition(
_get_rq_metadata,
lambda m: m.stats.read_count - stats_before.read_count >= len(requests),
)
stats_after = metadata.stats
Actor.log.info(stats_after)

Expand Down
Loading