Add firmware for Arduino UNO Q (QRB2210/QCM2290)#123
Conversation
Add WiFi (ath10k WCN3990), Bluetooth (QCA), GPU (Adreno a702), DSP (ADSP), modem, and video (Venus 6.0) firmware for the Qualcomm QCM2290 SoC used in the Arduino UNO Q board.
WalkthroughFive new JSON configuration files are added to the Estimated code review effort🎯 1 (Trivial) | ⏱️ ~5 minutes 🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
🧹 Nitpick comments (5)
qcom/qcm2290/adspr.jsn (1)
1-21: Consider adding a trailing newline for POSIX compliance.The file is missing a trailing newline at end of file. This is consistent with other files in this PR but may cause issues with certain text processing tools.
📝 Proposed fix to add trailing newline
] } +🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@qcom/qcm2290/adspr.jsn` around lines 1 - 21, The file ends without a trailing newline which can break POSIX tools; update the file (containing keys like "sr_version", "sr_domain", and "sr_service") to ensure there is a single newline character at the end of the file (i.e., add a trailing '\n' after the final closing brace) and commit the change so the file ends with a newline.qcom/qcm2290/modemuw.jsn (1)
1-33: Consider adding a trailing newline for POSIX compliance.The file is missing a trailing newline, consistent with other files in this PR. Consider adding one for better POSIX compliance.
📝 Proposed fix to add trailing newline
] } +🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@qcom/qcm2290/modemuw.jsn` around lines 1 - 33, The file's JSON object (starting with "sr_version") is missing a trailing newline at EOF; update the file qcm2290/modemuw.jsn by adding a single newline character at the end of the file so the top-level JSON (e.g., "sr_version", "sr_domain", "sr_service") ends with a POSIX-compliant trailing newline.qcom/qcm2290/modemr.jsn (1)
1-27: Consider adding a trailing newline for POSIX compliance.The file is missing a trailing newline. For consistency and to avoid potential issues with text processing tools, consider adding one.
📝 Proposed fix to add trailing newline
] } +🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@qcom/qcm2290/modemr.jsn` around lines 1 - 27, Add a POSIX-compliant trailing newline to the end of the JSON file by ensuring a newline character follows the final closing brace '}' (the end of the object containing "sr_version", "sr_domain", and "sr_service"); simply modify the file that defines the JSON object so the last byte is a newline character.qcom/qcm2290/adspua.jsn (1)
1-27: Consider adding a trailing newline for POSIX compliance.The file is missing a trailing newline. This is consistent across all files in this PR, but adding one would improve POSIX compliance.
📝 Proposed fix to add trailing newline
] } +🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@qcom/qcm2290/adspua.jsn` around lines 1 - 27, The file currently ends without a trailing newline; open the JSON file containing the top-level keys "sr_version", "sr_domain", and "sr_service" and ensure you add a single POSIX-compliant newline character at the end of the file (EOF) so the file ends with a newline.qcom/qcm2290/adsps.jsn (1)
1-21: Add trailing newline for POSIX compliance.The file is missing a trailing newline at end of file. This is a common practice for text files and aligns with POSIX standards.
Proposed fix
] } +Configuration validated against QCM2290 specifications.
The QMI instance ID (74), domain/subdomain naming (msm/adsp/sensor_pd), and service routing configuration (tms/servreg) align with Qualcomm QCM2290 ADSP sensor protection domain specifications and match the patterns used across other similar devices in the repository.
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@qcom/qcm2290/adsps.jsn` around lines 1 - 21, The file ends without a POSIX trailing newline; open the JSON file containing "sr_version" / "sr_domain" (note the "qmi_instance_id": 74 entry) and add a single newline character at EOF so the file terminates with a trailing newline while preserving all existing content and formatting.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In `@qcom/qcm2290/adspr.jsn`:
- Around line 1-21: The file ends without a trailing newline which can break
POSIX tools; update the file (containing keys like "sr_version", "sr_domain",
and "sr_service") to ensure there is a single newline character at the end of
the file (i.e., add a trailing '\n' after the final closing brace) and commit
the change so the file ends with a newline.
In `@qcom/qcm2290/adsps.jsn`:
- Around line 1-21: The file ends without a POSIX trailing newline; open the
JSON file containing "sr_version" / "sr_domain" (note the "qmi_instance_id": 74
entry) and add a single newline character at EOF so the file terminates with a
trailing newline while preserving all existing content and formatting.
In `@qcom/qcm2290/adspua.jsn`:
- Around line 1-27: The file currently ends without a trailing newline; open the
JSON file containing the top-level keys "sr_version", "sr_domain", and
"sr_service" and ensure you add a single POSIX-compliant newline character at
the end of the file (EOF) so the file ends with a newline.
In `@qcom/qcm2290/modemr.jsn`:
- Around line 1-27: Add a POSIX-compliant trailing newline to the end of the
JSON file by ensuring a newline character follows the final closing brace '}'
(the end of the object containing "sr_version", "sr_domain", and "sr_service");
simply modify the file that defines the JSON object so the last byte is a
newline character.
In `@qcom/qcm2290/modemuw.jsn`:
- Around line 1-33: The file's JSON object (starting with "sr_version") is
missing a trailing newline at EOF; update the file qcm2290/modemuw.jsn by adding
a single newline character at the end of the file so the top-level JSON (e.g.,
"sr_version", "sr_domain", "sr_service") ends with a POSIX-compliant trailing
newline.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 08fcd6bc-7c51-4f71-891b-43fa3585e98b
⛔ Files ignored due to path filters (4)
ath10k/WCN3990/hw1.0/board-2.binis excluded by!**/*.binath10k/WCN3990/hw1.0/firmware-5.binis excluded by!**/*.binath10k/WCN3990/hw1.0/qcm2290/firmware-5.binis excluded by!**/*.binqca/apnv11.binis excluded by!**/*.bin
📒 Files selected for processing (14)
ath10k/WCN3990/hw1.0/qcm2290/wlanmdsp.mbnath10k/WCN3990/hw1.0/wlanmdsp.mbnqca/apbtfw11.tlvqcom/a702_sqe.fwqcom/qcm2290/a702_zap.mbnqcom/qcm2290/adsp.mbnqcom/qcm2290/adspr.jsnqcom/qcm2290/adsps.jsnqcom/qcm2290/adspua.jsnqcom/qcm2290/modem.mbnqcom/qcm2290/modemr.jsnqcom/qcm2290/modemuw.jsnqcom/qcm2290/wlanmdsp.mbnqcom/venus-6.0/venus.mbn
Move firmware blobs to armbian/firmware repository (armbian/firmware#123) and remove manual firmware copies from post_family_tweaks. Firmware is now installed via the armbian-firmware package. Rename boot-qcom to boot-qrb2210 to be family-specific.
2 participants
Add WiFi (ath10k WCN3990), Bluetooth (QCA), GPU (Adreno a702), DSP (ADSP), modem, and video (Venus 6.0) firmware for the Qualcomm QCM2290 SoC used in the Arduino UNO Q board.
Related to armbian/build#9623