This repository was archived by the owner on Dec 15, 2022. It is now read-only.
Merged
Conversation
Contributor
Author
|
These changes were merged into the Calva Clojure IDE. BetterThanTomorrow/calva#1435 |
Contributor
Author
|
@kevinsawicki @50Wliu Hey, is this repository still maintained or is it abandoned? |
Contributor
|
Hey! @darangi and @sadick254 would be the two best equipped to answer that, I think. Let me look at this PR though and see if I have any comments. |
winstliu
approved these changes
Jan 19, 2022
Contributor
winstliu
left a comment
winstliu
left a comment
There was a problem hiding this comment.
Yep, looks about right.
Contributor
|
Thanks for the contribution 🙇🏾 @MrEbbinghaus |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the Change
This PR fixes several issues with number matching. (See #89)
+prefix.N, that includes octals, hexadecimals and arbitrary radixconstant.numeric.bigint.clojureintoconstant.numeric.long.clojureas it doesn't make any sense any more, to have it separate.constant.numeric.bigdecimal.clojureintoconstant.numeric.double.clojurefor consistency..is optional when followed bye,E,M\walso matches_which is incorrect.2rABZ) shouldn't be matched either, but I considered it overkill.8or9It also adds a bunch of tests to check for previously missed cases.
Alternate Designs
I considered constraining the changes to only eliminate false-negatives. (Change 5 and 6 are only fixing false-positives)
I opted against that because a more strict highlighting is the fastest way of feedback a developer can get.
Benefits
More accurate highlighting of numbers.
Possible Drawbacks
The matching is more strict. Some false-positives aren't highlighted any more. (Although not really a drawback, it is a breaking change if someone relies on current bugs... But, how would?)
Applicable Issues
resolves #89