Skip to content

Exclude non-essential files#52

Merged
b3by merged 2 commits intob3by:masterfrom
vinkla:patch-1
Nov 13, 2017
Merged

Exclude non-essential files#52
b3by merged 2 commits intob3by:masterfrom
vinkla:patch-1

Conversation

@vinkla
Copy link
Copy Markdown
Contributor

@vinkla vinkla commented Oct 3, 2017

This way the users of this package doesn't have to download non-essential files which aren't necessary for the package to function. Such as files used for development (docs, tests, .travis.yml, etc).

Happy Hacktoberfest!

vinkla added 2 commits October 3, 2017 22:24
This way the users of this package doesn't have to download non-essential files which aren't necessary for the package to function. Such as files used for development (docs, tests, .travis.yml, etc).

Happy Hacktoberfest!
@ftm
Copy link
Copy Markdown
Contributor

ftm commented Oct 5, 2017

I think README.md needs to be kept in order for Atom to display it when the package is installed

@b3by
Copy link
Copy Markdown
Owner

b3by commented Oct 5, 2017

Thank you for the commits. That's right, the readme is needed, and probably the image folder too.

@vinkla
Copy link
Copy Markdown
Contributor Author

vinkla commented Oct 5, 2017

I think README.md needs to be kept in order for Atom to display it when the package is installed

@frasertmay the README.md file is excluded from the list.

Thank you for the commits. That's right, the readme is needed, and probably the image folder too.

@b3by I would argue against keeping the images directory. We don't want to force the users of this package to download 1,2 megabytes of data they probably wont use. If we do the math of how many times this package has been downloaded we've used over 300 gigabytes of bandwidth data.

Instead I think we should upload the images to GitHub's CDN.

@vinkla
Copy link
Copy Markdown
Contributor Author

vinkla commented Nov 1, 2017

Any update on this? Will you merge or should I close?

@b3by
Copy link
Copy Markdown
Owner

b3by commented Nov 2, 2017

Sorry about the super late response. I'll merge this after Monday (quite sure I'll do it on Tuesday). Crazy busy at work :(

@ftm
Copy link
Copy Markdown
Contributor

ftm commented Nov 2, 2017

If you're going to remove the images folder then the URLs in the README need pointing to the CDN or they won't show up in Atom

@b3by b3by merged commit 8b3a48e into b3by:master Nov 13, 2017
Copy link
Copy Markdown

@rokoto8812 rokoto8812 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants