Add full-screen-only option#64
Merged
b3by merged 1 commit intob3by:masterfrom Jun 22, 2019
matthew-e-brown:full-screen-only
Merged
Add full-screen-only option#64b3by merged 1 commit intob3by:masterfrom matthew-e-brown:full-screen-only
b3by merged 1 commit intob3by:masterfrom
matthew-e-brown:full-screen-only
Conversation
Owner
|
Thanks for the PR! I just merged it, it looks nice indeed! If you don't mind I will just fix a couple of style things, but other than that it looks alright. |
Contributor
Author
|
Go right ahead! Thanks for the merge 😄 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello!
I was inspired to add this option from cmd-johnson/atom-battery-status, and I followed their code to implement this. I think it sticks with the simplicity that this package is aiming for. 😄
Hopefully I matched your programming style, I did my best to put my code in the right places. I've never developed on an
package before.