Add marinalia options for connection spec#62
Merged
arthurnn merged 4 commits intobasecamp:masterfrom Jul 20, 2017
Merged
Conversation
Add :db_host, :socket, :database marginalia for getting information out of the currently used pool spec. This makes it easier to debug things like per-model connection pools and switching connections at runtime.
Contributor
Author
Contributor
Author
|
Rails 3 doesn't seem to have connection pools. I'll update to handle that soon. |
Contributor
Author
|
3.2 has been fixed. 3.1 doesn't seem to have a good access to the connection pool from the adapter. I restricted the new comments to only the 3.2 and later versions instead of trying to hack the support back in. |
|
That seems sane to me. While Rails 3.1 and 3.2 are EOL, the support of them with this gem appears to still be required. |
Collaborator
|
Looks good to me.. |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add :db_host, :socket, :database marginalia for getting information out
of the currently used pool spec. This makes it easier to debug things
like per-model connection pools and switching connections at runtime.