DRAFT: Fix cargo version parsing for caret, tilde, and pre-release versions#1701
Draft
zahidblackduck wants to merge 8 commits intomasterfrom
Draft
DRAFT: Fix cargo version parsing for caret, tilde, and pre-release versions#1701zahidblackduck wants to merge 8 commits intomasterfrom
zahidblackduck wants to merge 8 commits intomasterfrom
Conversation
…TECT-5056-cargo-version-sanitization-bugfix-SNAPSHOT
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JIRA Ticket
IDETECT-5056
Description
This pull request aims to fix the cargo detectors failing with
NumberFormatExceptionwhenCargo.tomlversion strings contain operator prefixes (^,~) or pre-release tags (-alpha,-rc1). For example,syslog = "^6.0"caused extraction failure because the parser attempted to parse"^6"as an integer.Root Cause
VersionUtils.versionMatches()handled comparison operators (>=,>,<=,<,=) but not^or~, andcompareVersions()did not strip pre-release or build metadata before parsing.Implementation
CargoOperatorenum insideVersionUtilsto represent valid Cargo version operatorsstripBuildMetadata()tosanitizeVersion()to also strip pre-release tags before numeric parsingVersionUtilsTestN.B: This pull request is meant to be shipped with detect
11.5.0