Skip to content

Fix deprecation warning#1874

Closed
labrys wants to merge 2 commits intoboto:developfrom
labrys:patch-1
Closed

Fix deprecation warning#1874
labrys wants to merge 2 commits intoboto:developfrom
labrys:patch-1

Conversation

@labrys
Copy link
Copy Markdown

@labrys labrys commented Nov 6, 2019

DeprecationWarning: Using or importing the ABCs from 'collections' instead of from 'collections.abc' is deprecated since Python 3.3, and in 3.9 it will stop working

DeprecationWarning: Using or importing the ABCs from 'collections' instead of from 'collections.abc' is deprecated since Python 3.3, and in 3.9 it will stop working
@codecov-io
Copy link
Copy Markdown

Codecov Report

Merging #1874 into develop will decrease coverage by 0.71%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1874      +/-   ##
===========================================
- Coverage    92.56%   91.84%   -0.72%     
===========================================
  Files           53       53              
  Lines        10001    10001              
===========================================
- Hits          9257     9185      -72     
- Misses         744      816      +72
Impacted Files Coverage Δ
botocore/awsrequest.py 92.13% <100%> (-6.23%) ⬇️
botocore/compat.py 68.5% <0%> (-25.42%) ⬇️
botocore/hooks.py 95.18% <0%> (-1.21%) ⬇️
botocore/handlers.py 96.45% <0%> (-0.48%) ⬇️
botocore/utils.py 97.81% <0%> (-0.17%) ⬇️
botocore/credentials.py 98.4% <0%> (-0.12%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 66f46fd...72c4519. Read the comment docs.

@BoboTiG
Copy link
Copy Markdown

BoboTiG commented Nov 6, 2019

You should use that kind of code to fix the CI and Python 2 errors:

try:
   from collections.abc import MutableMapping
except ImportError:
   from collections import MutableMapping

Ad then use MutableMapping in class declaration.

@BoboTiG
Copy link
Copy Markdown

BoboTiG commented Nov 6, 2019

My bad, it did no see that this is a duplicate of #1865.

@labrys
Copy link
Copy Markdown
Author

labrys commented Nov 17, 2019

Closing as duplicate

@labrys labrys closed this Nov 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants