Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #345 +/- ##
=======================================
Coverage 86.47% 86.47%
=======================================
Files 27 27
Lines 1220 1220
=======================================
Hits 1055 1055
Misses 165 165 ☔ View full report in Codecov by Sentry. |
alessandrofelder
approved these changes
May 16, 2024
Member
alessandrofelder
left a comment
alessandrofelder
left a comment
There was a problem hiding this comment.
Approving, with the intent of moving examples to docs, and test-data to GIN in the future.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR moves the
resourcesdirectory to the top level. It always struck me as strange that it was shipped with the package.Tests and examples updated.
Closes #314