Allow examples/neurons.py to run successfully when neuromorpho is down#366
Merged
adamltyson merged 7 commits intomainfrom Jun 7, 2024
Merged
Allow examples/neurons.py to run successfully when neuromorpho is down#366adamltyson merged 7 commits intomainfrom
adamltyson merged 7 commits intomainfrom
Conversation
…neuromorpho is down
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #366 +/- ##
==========================================
+ Coverage 86.96% 87.39% +0.42%
==========================================
Files 27 27
Lines 1220 1214 -6
==========================================
Hits 1061 1061
+ Misses 159 153 -6 ☔ View full report in Codecov by Sentry. |
adamltyson
approved these changes
Jun 7, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before submitting a pull request (PR), please read the contributing guide.
Please fill out as much of this template as you can, but if you have any problems or questions, just leave a comment and we will help out :)
Description
What is this PR
Why is this PR needed?
The test running each example script occasionally fails when neuromorpho.org is down.
What does this PR do?
Place the code relating to connecting to neuromorpho.org in a try-catch block that allows the example to still run if a
ConnnectionErroris encountered.References
How has this PR been tested?
Tested locally,
examples/neurons.pycan be run and renders the neuron stored locally.Is this a breaking change?
No
Does this PR require an update to the documentation?
No
If any features have changed, or have been added. Please explain how the documentation has been updated (and link to the associated PR). See here for details.
Checklist: