Skip to content

Allow examples/neurons.py to run successfully when neuromorpho is down#366

Merged
adamltyson merged 7 commits intomainfrom
add-guards-for-neuromorpho
Jun 7, 2024
Merged

Allow examples/neurons.py to run successfully when neuromorpho is down#366
adamltyson merged 7 commits intomainfrom
add-guards-for-neuromorpho

Conversation

@IgorTatarnikov
Copy link
Copy Markdown
Member

Before submitting a pull request (PR), please read the contributing guide.

Please fill out as much of this template as you can, but if you have any problems or questions, just leave a comment and we will help out :)

Description

What is this PR

  • Bug fix
  • Addition of a new feature
  • Other

Why is this PR needed?
The test running each example script occasionally fails when neuromorpho.org is down.

What does this PR do?
Place the code relating to connecting to neuromorpho.org in a try-catch block that allows the example to still run if a ConnnectionError is encountered.

References

How has this PR been tested?

Tested locally, examples/neurons.py can be run and renders the neuron stored locally.

Is this a breaking change?

No

Does this PR require an update to the documentation?

No

If any features have changed, or have been added. Please explain how the documentation has been updated (and link to the associated PR). See here for details.

Checklist:

  • The code has been tested locally
  • Tests have been added to cover all new functionality (unit & integration)
  • The documentation has been updated to reflect any changes
  • The code has been formatted with pre-commit

@codecov
Copy link
Copy Markdown

codecov bot commented Jun 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.39%. Comparing base (48f655f) to head (3e2ebbf).
Report is 18 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #366      +/-   ##
==========================================
+ Coverage   86.96%   87.39%   +0.42%     
==========================================
  Files          27       27              
  Lines        1220     1214       -6     
==========================================
  Hits         1061     1061              
+ Misses        159      153       -6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@IgorTatarnikov IgorTatarnikov requested a review from a team June 7, 2024 08:21
@adamltyson adamltyson merged commit f1e3785 into main Jun 7, 2024
@adamltyson adamltyson deleted the add-guards-for-neuromorpho branch June 7, 2024 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants