Added an example to dynamically alter the scene in each frame#376
Merged
IgorTatarnikov merged 6 commits intomainfrom Aug 20, 2024
Merged
Added an example to dynamically alter the scene in each frame#376IgorTatarnikov merged 6 commits intomainfrom
IgorTatarnikov merged 6 commits intomainfrom
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #376 +/- ##
==========================================
- Coverage 88.06% 86.62% -1.44%
==========================================
Files 27 27
Lines 1215 1219 +4
==========================================
- Hits 1070 1056 -14
- Misses 145 163 +18 ☔ View full report in Codecov by Sentry. |
alessandrofelder
approved these changes
Aug 20, 2024
Member
alessandrofelder
left a comment
There was a problem hiding this comment.
Looks good, tiny comment about documenting arguments.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before submitting a pull request (PR), please read the contributing guide.
Please fill out as much of this template as you can, but if you have any problems or questions, just leave a comment and we will help out :)
Description
What is this PR
Why is this PR needed?
See https://forum.image.sc/t/brainrender-animation-of-slices/100612
What does this PR do?
Adds a new flag to
make_videoto fix the camera to the perspective of the first frame. Otherwise, if the root mesh is sliced throughout the animation the perspective will shift as the centre of mass of the root volume shifts.Passes the callback function to subsequent frames after the last frame.
Adds an example for how to use a callback function to dynamically alter the scene throughout the Animation.
How has this PR been tested?
All tests pass locally.
Is this a breaking change?
No, the new flag is optional and the default provides the previous behaviour.
Does this PR require an update to the documentation?
Yes, will come in subsequent PR.
Checklist: