update tests and pyproject to latest vedo#407
Conversation
this is because new vedo returns different bounds for gene actor
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #407 +/- ##
=======================================
Coverage 86.62% 86.62%
=======================================
Files 27 27
Lines 1241 1241
=======================================
Hits 1075 1075
Misses 166 166 ☔ View full report in Codecov by Sentry. |
thanks for reporting, it's hard to guess for me, if it's a text actor that's possible. If it's a |
|
It's a legosurface, so that explains it. @alessandrofelder do we know which version of the bounds calculation is correct, or at least most appropriate for our use? |
|
Our test checks whether the bounds of a legosurface (200um pixel size) containing high levels of GPR161 expression match the bounds of the CA1 mesh (a region where we expect lots of GPR161, I presume) The bounds comparison was approximate anyway (we expand the CA1 mesh bounds by 500um before comparing, and now 600um for the new vedo). Given the resolution of the gene expression data and the fact that the test is approximate,
My guess is that it's a question of defining whether in brainrender we think of pixel coordinates as on the "corner" or in the "centre" of the pixel volume, and we should probably do what |
Sounds fine to me! |
Description
What is this PR
Why is this PR needed?
Scheduled tests failed, because of API changes in latest
vedoWhat does this PR do?
Update tests to match new API, and require latest vedo in
pyproject.tomlAlso, makes a bounds tests less strict - this is fine for our purposes, but worth flagging to @marcomusy that the
geneactor intest_integration.py::test_gene_expressionreturns different bounds forvedo2024.5.2 and 2025.5.2 - is this expected?(output of a bash script that installs the
vedoversions and then calls a Python script that prints the actor's bounds)