[Fix] resolution when filename option is passed#167
Merged
Conversation
PR #162 introduced a `parent` variable that contains either the full filename of the requiring module or the `basedir`. Some of the places where `basedir` was used were updated to use `parent` instead, but that's not correct; the `path.resolve()` calls would receive the full filename instead of the directory name. This patch reverts the improper `parent` uses to `basedir`.
ljharb
approved these changes
Jun 17, 2018
Member
ljharb
left a comment
ljharb
left a comment
There was a problem hiding this comment.
Thanks, appreciate the test cases!
Member
|
Released in v1.8.1 |
This was referenced Dec 2, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR #162 introduced a
parentvariable that contains either the fullfilename of the requiring module or the
basedir. Some of the placeswhere
basedirwas used were updated to useparentinstead, butthat's not correct; the
path.resolve()calls would receive the fullfilename instead of the directory name.
This patch reverts the improper
parentuses tobasedir.