Merged
Conversation
arcanis
force-pushed
the
skipnodemodules
branch
from
a267891 to
eaace7a
Compare
…ceive a thunk for node modules resolution paths - this would be a breaking change, but the “paths as function” option has not yet been released.
ljharb
reviewed
Nov 22, 2018
Member
ljharb
left a comment
ljharb
left a comment
There was a problem hiding this comment.
Thinking about this more; what would you think about making the paths function be passed a thunk, so it can choose for itself what to do with the node_modules resolution?
On the hopes that it'll work for you, I've updated this PR with that change :-)
ljharb
force-pushed
the
skipnodemodules
branch
from
eaace7a to
9ea8b16
Compare
Contributor
Author
|
@ljharb yep, that's good to me! 😃 |
ljharb
approved these changes
Nov 28, 2018
ljharb
added a commit
that referenced
this pull request
Dec 17, 2018
- [New] `async`/`sync`/`node-modules-paths`: Adds support for “paths” being a function (#172, #173) - [New] Implements a "normalize-options" pseudo-hook (#174) - [Fix] `sync`/`async`: fix `preserveSymlinks` option (#177) - [Fix] `sync`/`async`: when package.json `main` is not a string, throw an error (#178) - [Deps] update `path-parse` - [Dev Deps] update `eslint`, `@ljharb/eslint-config`, `object-keys`, `safe-publish-latest`, `tape` - [Tests] up to `node` `v11.4`, `v10.14`, `v8.14`, `v6.15` - [Tests] better failure messages
6 tasks
This was referenced Dec 2, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Split out of #170.
This PR adds support for a new
skipNodeModulesoption. This option can be used to preventresolvefrom doing lookups fornode_modules. It's an advanced option that likely won't be used by direct users, but that's important for the PnP use case (otherwise people could have weird behaviors if they happen to also have anode_moduleson top of their.pnp.jsfile - for example if they rannpm installat some point).