feat: support error context in stream/error operations#1149
Merged
dicej merged 2 commits intobytecodealliance:mainfrom Feb 14, 2025
Merged
feat: support error context in stream/error operations#1149dicej merged 2 commits intobytecodealliance:mainfrom
dicej merged 2 commits intobytecodealliance:mainfrom
Conversation
dicej
reviewed
Jan 30, 2025
Collaborator
dicej
left a comment
dicej
left a comment
There was a problem hiding this comment.
I haven't had time to look at this super thoroughly yet, but looking good so far. See comments inline.
dicej
reviewed
Jan 30, 2025
Collaborator
dicej
left a comment
dicej
left a comment
There was a problem hiding this comment.
LGTM, but let's hold off merging this until we have some end-to-end test coverage in (your or my branch of) Wasmtime, e.g. tests that exercise closing with an error and verifying the reader receives it. We should test both the "local" case (i.e. when the same component instance has both ends of the stream/future) and the "remote" case (where the reader and writer ends are owned by different component instances).
Signed-off-by: Victor Adossi <vadossi@cosmonic.com>
vados-cosmonic
force-pushed
the
fix=pass-along-error-context
branch
from
5a0ac8c to
7ac0f08
Compare
Signed-off-by: Victor Adossi <vadossi@cosmonic.com>
Contributor
Author
|
Just a note: there are now working tests that use the functionality in here: |
dicej
approved these changes
Feb 14, 2025
dicej
pushed a commit
to dicej/wit-bindgen
that referenced
this pull request
Feb 14, 2025
…nce#1149) * feat: support error context in stream/error operations Signed-off-by: Victor Adossi <vadossi@cosmonic.com> * fix: ensure late drop Signed-off-by: Victor Adossi <vadossi@cosmonic.com> --------- Signed-off-by: Victor Adossi <vadossi@cosmonic.com> Signed-off-by: Joel Dice <joel.dice@fermyon.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.