Add CTD thermal lag correction, YAML constants reader, and GSW salini…#234
Open
lauryntalbot wants to merge 8 commits intoc-proof:mainfrom
Open
Add CTD thermal lag correction, YAML constants reader, and GSW salini…#234lauryntalbot wants to merge 8 commits intoc-proof:mainfrom
lauryntalbot wants to merge 8 commits intoc-proof:mainfrom
Conversation
jklymak
reviewed
Mar 20, 2026
jklymak
reviewed
Mar 20, 2026
jklymak
reviewed
Mar 20, 2026
jklymak
reviewed
Mar 20, 2026
jklymak
reviewed
Mar 20, 2026
jklymak
reviewed
Mar 20, 2026
jklymak
reviewed
Mar 20, 2026
| "tau": tau, | ||
| "dTdC": dTdC, | ||
| } | ||
| def ctd_constants(deployfile, *, alpha=None, tau=None, dTdC=None): |
Member
There was a problem hiding this comment.
same here - the yaml is already read?
jklymak
reviewed
Mar 20, 2026
jklymak
reviewed
Mar 20, 2026
Member
jklymak
left a comment
jklymak
left a comment
There was a problem hiding this comment.
Ideally this would have some documentation and an example as part of pyglider. As it is, it's a bit mysterious. Bonus points if you have a test.
jklymak
reviewed
Mar 20, 2026
jklymak
reviewed
Mar 20, 2026
jklymak
reviewed
Mar 20, 2026
| @@ -0,0 +1,6 @@ | |||
| { | |||
jklymak
reviewed
Mar 20, 2026
| @@ -0,0 +1,118 @@ | |||
| # PyGlider: Adjust CTD variables | |||
Member
There was a problem hiding this comment.
This needs to be incorporated in the rest of the docs somehow.
Member
|
This is going to have a doc warning because your new markdown is not in a table of contents anywhere. Please add to the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ty updates