CTD_adjusted#237
Open
lauryntalbot wants to merge 12 commits intoc-proof:mainfrom
Open
Conversation
added 7 commits
April 21, 2026 15:34
Author
SummaryThis PR adds a new CTD post-processing workflow for generating adjusted timeseries and gridded products, including thermal lag and CT lag corrections. The workflow produces Code Changespyglider/ncprocess.py
pyglider/utils.py
pyglider/process_adjusted.py
Documentation Updatesdocs/adjust_CTD.md
docs/index.md
TestsAdded tests validating the workflow for multiple glider platforms:
These tests:
Test DataYAML inputs
Expected outputs
Notes
|
3436c5b to
e203598
Compare
Member
|
@lauryntalbot what is the status here? I should be able to review tomorrow |
jklymak
reviewed
Apr 30, 2026
|
|
||
| sal_adj.attrs = ts.salinity.attrs.copy() | ||
|
|
||
| if dTdC is not None: |
Member
There was a problem hiding this comment.
Why is this all in the docs? I'm confused.
jklymak
reviewed
Apr 30, 2026
| Parameters | ||
| ---------- | ||
| ds: DataArray | ||
| Timeseries of mission data |
Member
There was a problem hiding this comment.
Similarly, this should not be in the docs?
jklymak
reviewed
Apr 30, 2026
| fn: float | ||
| Sampling frequency of the sensor | ||
|
|
||
| alpha : float |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
added CTD_adjusted.py, tests and documentation