Skip to content

fix: Cropping an image while considering ExifInterface.TAG_ORIENTATION on Android#133

Merged
retyui merged 1 commit intomasterfrom
fix/retyui/img-orientation
Feb 7, 2024
Merged

fix: Cropping an image while considering ExifInterface.TAG_ORIENTATION on Android#133
retyui merged 1 commit intomasterfrom
fix/retyui/img-orientation

Conversation

@retyui
Copy link
Copy Markdown
Collaborator

@retyui retyui commented Feb 5, 2024

Summary

After merging this PR users will be able to crop images with different exif orientation

image

read more: https://jdhao.github.io/2019/07/31/image_rotation_exif_info/

Test plan

Orientation (0, 90, 180, 270):

Before After
Screen_Recording_20240205_211357_Rn73.mp4
Screen_Recording_20240205_211012_Gallery.mp4

@retyui retyui marked this pull request as ready for review February 5, 2024 21:29
@retyui retyui requested a review from mateusz1913 February 5, 2024 21:29
@retyui retyui changed the title fix: Cropping an image while considering ExifInterface.TAG_ORIENTATION fix: Cropping an image while considering ExifInterface.TAG_ORIENTATION on Android Feb 5, 2024
@retyui retyui marked this pull request as draft February 5, 2024 23:41
@retyui
Copy link
Copy Markdown
Collaborator Author

retyui commented Feb 6, 2024

an issue with RN-vision-camera:

UPD: known issue, not a blocker: mrousavy/react-native-vision-camera#2515

@retyui retyui marked this pull request as ready for review February 6, 2024 21:27
@retyui retyui force-pushed the fix/retyui/img-orientation branch from 66c5bc1 to 030d873 Compare February 7, 2024 11:58
Copy link
Copy Markdown
Contributor

@mateusz1913 mateusz1913 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@retyui retyui merged commit 27167a2 into master Feb 7, 2024
@retyui retyui deleted the fix/retyui/img-orientation branch February 7, 2024 15:06
@retyui retyui mentioned this pull request Feb 19, 2024
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants