Skip to content

feature: Add base64 output#144

Merged
retyui merged 1 commit intomasterfrom
feature/retyui/base64
Feb 25, 2024
Merged

feature: Add base64 output#144
retyui merged 1 commit intomasterfrom
feature/retyui/base64

Conversation

@retyui
Copy link
Copy Markdown
Collaborator

@retyui retyui commented Feb 23, 2024

Summary

Changes

  • Update README.md
  • Add base64 output support
  • Add a new result prop type: 'image/jpeg' | 'image/webp' | 'image/png'
  • Add Typescript tests

Test plan

...

@retyui retyui force-pushed the feature/retyui/base64 branch 2 times, most recently from fa3089d to ce8f652 Compare February 23, 2024 17:16
@retyui retyui marked this pull request as ready for review February 23, 2024 17:19
@retyui retyui requested a review from mateusz1913 February 23, 2024 17:19
@retyui retyui mentioned this pull request Feb 23, 2024
8 tasks
Comment thread src/NativeRNCImageEditor.ts Outdated
@retyui retyui force-pushed the feature/retyui/base64 branch from ce8f652 to eeec3fe Compare February 24, 2024 15:42
@retyui retyui requested a review from mateusz1913 February 24, 2024 15:43
Copy link
Copy Markdown
Contributor

@mateusz1913 mateusz1913 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@retyui retyui merged commit 764f6ec into master Feb 25, 2024
@retyui retyui deleted the feature/retyui/base64 branch February 25, 2024 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants