fix: unblock build for 0.76#660
Merged
BartoszKlonowski merged 1 commit intocallstack:mainfrom Oct 17, 2024
Merged
Conversation
okwasniewski
approved these changes
Oct 16, 2024
Contributor
Author
|
@BartoszKlonowski can we please get this released soon? 0.76 is right behind the corner. |
Member
|
Hello @vonovak! |
3 tasks
vonovak
added a commit
to expo/expo
that referenced
this pull request
Oct 27, 2024
# Why to resolve callstack/react-native-slider#652 callstack/react-native-slider#660 # How updated the package # Test Plan slider works in bare expo. iOS is smooth, Android is somewhat "jumpy" which I'll report to the package maintainers # Checklist <!-- Please check the appropriate items below if they apply to your diff. This is required for changes to Expo modules. --> - [ ] Documentation is up to date to reflect these changes (eg: https://docs.expo.dev and README.md). - [ ] Conforms with the [Documentation Writing Style Guide](https://github.com/expo/expo/blob/main/guides/Expo%20Documentation%20Writing%20Style%20Guide.md) - [ ] This diff will work correctly for `npx expo prebuild` & EAS Build (eg: updated a module plugin).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
the recently released 4.5.4 won't build when installed into a RN 0.76 project, due to breaking changes described in react-native-community/discussions-and-proposals#816
This PR fixes the build in a backward-compatible way, as recommended in the link above
the build failure:
and a bunch more of the same kind
Test Plan:
tested inside my fork at https://github.com/vonovak/react-native-slider/tree/fix/new-arch-issues
I used
"react-native-test-app": "^3.10.15", "react-native": "0.76.0-rc.5"