Skip to content

combined load slide page and table page#226

Merged
birm merged 2 commits intocamicroscope:developfrom
vikasgola:load-slide
Mar 4, 2020
Merged

combined load slide page and table page#226
birm merged 2 commits intocamicroscope:developfrom
vikasgola:load-slide

Conversation

@vikasgola
Copy link
Copy Markdown
Contributor

@vikasgola vikasgola commented Mar 4, 2020

Fix Issue camicroscope/Distro#97

Added Load slide option to table page and removed load slide page.

image

image

Copy link
Copy Markdown
Member

@birm birm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is pretty good. Minor change; can the slide upload hidden by default, but have a button to expand?

@vikasgola
Copy link
Copy Markdown
Contributor Author

@birm

Here are the changes...

image

image

@vikasgola vikasgola requested a review from birm March 4, 2020 18:40
@birm birm changed the base branch from master to develop March 4, 2020 18:44
Copy link
Copy Markdown
Member

@birm birm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That works! Thanks for taking the time!

@birm birm merged commit 2baa72c into camicroscope:develop Mar 4, 2020
@birm
Copy link
Copy Markdown
Member

birm commented Mar 9, 2020

Hey; I'm sorry to revive this, but @nanli-emory has pointed out that the sort functionality and the filter/search bar seem to be missing. Can you put in a second PR fixing that functionality?

viditvarshney added a commit to viditvarshney/caMicroscope that referenced this pull request Mar 10, 2020
birm pushed a commit that referenced this pull request Mar 10, 2020
birm pushed a commit that referenced this pull request Mar 10, 2020
* impoving the instructions in #226

* solved mismatch navbars, added favicon, remove unecessary css
@vikasgola vikasgola deleted the load-slide branch March 13, 2020 17:31
birm pushed a commit that referenced this pull request Mar 18, 2020
* impoving the instructions in #226

* solved mismatch navbars, added favicon, remove unecessary css

* some needed modifications

* feature: Signup option

* added Email Validation, Remove unnecessory Code
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants