Show Upload Options on Table when no slides#249
Show Upload Options on Table when no slides#249birm merged 7 commits intocamicroscope:developfrom AbdulRashidReshamwala:developer
Conversation
For 3.6.0 Release
birm
left a comment
birm
left a comment
There was a problem hiding this comment.
Good catch; that's what I get for testing without clearing my slides each time.
|
For future reference, it's easier to review PRs when you use a different topic branch for each change. |
birm
changed the title
|
@viditvarshney take a look at attached screenshots earlier when there was no data the modal and the buttons to upload were being overwritten with "No Data Found x..x" |
|
no, i am asking of this particular commit which has a message of "fix upload issues" |
birm
left a comment
birm
left a comment
There was a problem hiding this comment.
Actually, can we put the upload and reload buttons above the table?
|
@birm , sir when the files are uploaded then the upload and reload buttons are automatically above the table |
|
So, what has happened is that when no slides are present, the "no data" message would overwrite the table. That also meant that the upload/reload buttons were removed from the DOM. I missed this since I usually test from the test_seed data which adds a slide by default. |
|
I have made the required changes. |
|
ohh yeah sir i recently noticed that 🙂
…On Wed, Mar 25, 2020, 10:17 PM Ryan Birmingham ***@***.***> wrote:
So, what has happened is that when no slides are present, the "no data"
message would overwrite the table. That also meant that the upload/reload
buttons were removed from the DOM. I missed this since I usually test from
the test_seed data which adds a slide by default.
@AbdulRashidReshamwala <https://github.com/AbdulRashidReshamwala> has
fixed this, by moving it below the table. I just want them to move it back
above :)
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#249 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AIETYZN2YIPRV3PACOR5CLTRJIYTFANCNFSM4LTRFLOA>
.
|
* fixed missing id in app/signup/signup.html * added missing id attribute to in put field in apps/signup/signup.html * fixed missing id attribute of email input field in apps/signup/signup.html * fixed issue where upload and reload pages would not show if there was no data * fix upload issues * Moved buttons above the table Co-authored-by: Ryan Birmingham <birm@rbirm.us>
3 participants
Due to line 286 in apps/table.html both the upload and reload buttons as well as the upload modal was removed
Before
After
fixes #248