Skip to content

Signup Page UI Redesign#256

Merged
birm merged 1 commit intocamicroscope:developfrom
akhil-rana:Signup-PageUI-Redesign
Mar 27, 2020
Merged

Signup Page UI Redesign#256
birm merged 1 commit intocamicroscope:developfrom
akhil-rana:Signup-PageUI-Redesign

Conversation

@akhil-rana
Copy link
Copy Markdown
Contributor

The new design matches consistently with the whole application.
Some changes are:

  1. Improved email text field validation.
  2. The "id" attribute was missing in the email "input" which caused in "can't read property of null". Now it's fixed.
  3. Dropdown select option for user type has been added instead of previously used radio buttons.
  4. Addition of bootstrap, fontawesome (for icons)

sample

Copy link
Copy Markdown
Member

@birm birm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is fine for now since it sidesteps #254 entirely. @nanli-emory has the real review power here though

@birm birm requested a review from nanli-emory March 27, 2020 00:00
@birm birm merged commit 5964993 into camicroscope:develop Mar 27, 2020
@akhil-rana akhil-rana deleted the Signup-PageUI-Redesign branch March 27, 2020 00:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants