Remove camel case ignore rule in ESLint#278
Conversation
birm
left a comment
birm
left a comment
There was a problem hiding this comment.
still combing through, but you need to change anno_delete at
caMicroscope/apps/viewer/init.js
Line 876 in 75561af
|
@birm , @nanli-emory , the required changes have been made |
|
See caMicroscope/apps/viewer/init.js Line 1010 in 75561af |
|
@birm thanks for the review ! I checked all the html and js files once again and found some more changes to be required in table.html and init.js. I have made the required changes. I think now it should be fine. |
…into remove_camel_case
merge request camicroscope#278 variable name changing ====> `_target_viewer` => `_targetViewer`.
1. `toolbar._main_tools` => `toolbar._mainTools`, there are 8 places in `apps/veiwer/uicallbacks.js` that need to change when you change the variable`_main_tools` to `_mainTools` in `components/toolbar/toolbar.js`. [line 17, 23, 1053, 1079, 1092, 1096, 1215, 1221] 2. `toolbar._sub_tools` => `toolbar._subTools`, there are 3 places in `apps/segment/segment.js`(2 places - line 850, 851 removed), `apps/labeling/labeling.js` (1 place - line 84) that need to change when you change the variable`_sub_tools` to `_subTools` in `components/toolbar/toolbar.js`.
`toolbar._sub_tools` => `toolbar._subTools`
`toolbar._sub_tools` => `toolbar._subTools`
nanli-emory
left a comment
nanli-emory
left a comment
There was a problem hiding this comment.
@birm I approved the merge but I'm not confident that we have found and changed all variables to camel case since this changing involves in a large scale of files. I'm afraid that some uncaught code will crush some functionalities. 😥
|
@birm , I have updated this PR to resolve merge conflicts. Please review. |
3 participants
Fixes a subissue of #274
I have made sure that the application works, as earlier.
@birm , please review.