Merged
Conversation
Member
|
Ah, this is what happens when we both try to do a fix at the same time. I think that cd00a7b also fixes, but keeps the name duplicate checking; does it work for you? |
Contributor
Author
|
the |
birm
approved these changes
Apr 13, 2020
Member
|
Thanks for catching this. I guess I must've confused a revert for new code, or something like that. |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The check duplicate name feature was added in #318 and was fixed in #327 . But the bug was again added in #348 as some of the old code was added back. This PR fixes the bug .
Also earlier the feature worked only after refreshing the table as the
modelNamewas only updated during initialization which meant same name model could be uploaded in the same session. This has also been fixed .