Skip to content

Slide name change functionality & direct slide delete in No-Security Mode#367

Merged
birm merged 7 commits intocamicroscope:developfrom
akhil-rana:slideNameUpdate
Apr 15, 2020
Merged

Slide name change functionality & direct slide delete in No-Security Mode#367
birm merged 7 commits intocamicroscope:developfrom
akhil-rana:slideNameUpdate

Conversation

@akhil-rana
Copy link
Copy Markdown
Contributor

Slide name can be updated by the user who have the proper permissions.
ezgif-2-43ced679a2b2

@birm birm self-requested a review April 15, 2020 14:45
@akhil-rana akhil-rana changed the title Slide name change functionality Slide name change functionality & direct slide delete in No-Security Mode Apr 15, 2020
@akhil-rana
Copy link
Copy Markdown
Contributor Author

The delete functionality is now checked using the user permissions rather than userType, so slide deletion can now be directly done if security is turned off.
Also, for user who can delete directly, 'delete' text inside the button is replaced by only the icon, like before.

Copy link
Copy Markdown
Member

@birm birm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for the feature and fix!

@birm birm merged commit e5e7d36 into camicroscope:develop Apr 15, 2020
@birm birm mentioned this pull request Apr 17, 2020
@akhil-rana akhil-rana deleted the slideNameUpdate branch June 18, 2020 21:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants