UI responsive#477
Merged
birm merged 2 commits intocamicroscope:developfrom Jan 25, 2021
sohamsshah:UI-responsive
Merged
Conversation
birm
approved these changes
Jan 19, 2021
Member
birm
left a comment
There was a problem hiding this comment.
Looks ok to me, but I think @nanli-emory should review too, since collections are their WIP
Contributor
Author
|
Hey guys is there anything left for me to do so that this pr gets merged in. Thank you😁 |
nanli-emory
approved these changes
Jan 25, 2021
Contributor
Author
|
Thank you for review and approval :)) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds responsiveness and fixes UI issues in the table.html page.
Motivation and Context
**Why is this change required? What problem does it solve?
How Has This Been Tested?
**This has been tested by resizing window and running the application in different browser environments as well. This is a UI fix, so expecting that this much testing is enough.
Screenshots (if appropriate):
The SS of the existing development hosted setup can be found in the #473.
The below snapshots are after fix.
Types of changes
**What types of changes does your code introduce? Put an
xin all the boxes that apply:Checklist:
**Go over all the following points, and put an
xin all the boxes that apply.**(If you're unsure about any of these, don't hesitate to ask. We're here to help!)
Please review this PR and let me know how does this sound. If there are any changes/clarifications needed, I will be happy to address them.