Skip to content

UI responsive#477

Merged
birm merged 2 commits intocamicroscope:developfrom
sohamsshah:UI-responsive
Jan 25, 2021
Merged

UI responsive#477
birm merged 2 commits intocamicroscope:developfrom
sohamsshah:UI-responsive

Conversation

@sohamsshah
Copy link
Copy Markdown
Contributor

Description

This PR adds responsiveness and fixes UI issues in the table.html page.

Motivation and Context

**Why is this change required? What problem does it solve?

How Has This Been Tested?

**This has been tested by resizing window and running the application in different browser environments as well. This is a UI fix, so expecting that this much testing is enough.

Screenshots (if appropriate):

The SS of the existing development hosted setup can be found in the #473.

The below snapshots are after fix.

  • Duplicates removed.
    duplicate_1
  • Add responsiveness.
    responsive

Types of changes

**What types of changes does your code introduce? Put an x in all the boxes that apply:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

**Go over all the following points, and put an x in all the boxes that apply.
**(If you're unsure about any of these, don't hesitate to ask. We're here to help!)

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

Please review this PR and let me know how does this sound. If there are any changes/clarifications needed, I will be happy to address them.

Copy link
Copy Markdown
Member

@birm birm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ok to me, but I think @nanli-emory should review too, since collections are their WIP

@birm birm requested a review from nanli-emory January 19, 2021 23:39
@sohamsshah
Copy link
Copy Markdown
Contributor Author

Hey guys is there anything left for me to do so that this pr gets merged in.

Thank you😁

@birm birm mentioned this pull request Jan 25, 2021
5 tasks
@birm birm merged commit 013c5c0 into camicroscope:develop Jan 25, 2021
@sohamsshah sohamsshah deleted the UI-responsive branch January 26, 2021 04:18
@sohamsshah
Copy link
Copy Markdown
Contributor Author

Thank you for review and approval :))

@r7rohan r7rohan mentioned this pull request Feb 9, 2021
1 task
This was referenced Mar 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants