Skip to content

improve tour resume UX#487

Merged
birm merged 3 commits intocamicroscope:developfrom
sohamsshah:tour
Feb 13, 2021
Merged

improve tour resume UX#487
birm merged 3 commits intocamicroscope:developfrom
sohamsshah:tour

Conversation

@sohamsshah
Copy link
Copy Markdown
Contributor

Description

Solves #481
It is a UX improvement in tour.
What this change does?

  • The tour that is provided for ease for users to understand if left in between, continues from where the user left i.e. default.
  • But generally by UX perspective, the tour must start from the beginning because of the following problems:
    • If the tour is left at the end, it resumes from the end and doesn't again point to start.
    • If the user closes the window and when opens again, the local storage has stored the value of last left tour element. And thus will resume from there itself; which is unexpected for user as User would expect it to be from beginning only.

How Has This Been Tested?

**Please describe in detail how you tested your changes.

  • It changes tut.js file. It has been tested for its working on local set up.

Types of changes

**What types of changes does your code introduce? Put an x in all the boxes that apply:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

**Go over all the following points, and put an x in all the boxes that apply.
**(If you're unsure about any of these, don't hesitate to ask. We're here to help!)

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

Please let me know how does this sounds. Would love to know your suggestions or improvements on this!

@birm birm changed the base branch from master to develop February 10, 2021 15:35
Copy link
Copy Markdown
Member

@birm birm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you fix the lint job? npm run lint-fix should probably do it.

@sohamsshah
Copy link
Copy Markdown
Contributor Author

sohamsshah commented Feb 12, 2021

Hi, I have resolved the linting errors. Anything else I can do to get this change merged?

Copy link
Copy Markdown
Member

@birm birm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix, and the improvement!

@birm birm merged commit af80227 into camicroscope:develop Feb 13, 2021
@sohamsshah sohamsshah deleted the tour branch February 16, 2021 07:55
This was referenced Mar 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants